Darwin base chip cluster #4883
Merged
Darwin base chip cluster #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
pan-apple,
rwalker-apple,
saurabhst and
woody-apple
msandstedt
approved these changes
Feb 16, 2021
jelderton
approved these changes
Feb 17, 2021
woody-apple
approved these changes
Feb 18, 2021
|
@vivien-apple conflicts here :( |
vivien-apple
force-pushed
the
Darwin_BaseCHIPCluster
branch
from
7bafaf8 to
e985538
Compare
vivien-apple
force-pushed
the
Darwin_BaseCHIPCluster
branch
from
e985538 to
f5cd129
Compare
vivien-apple
force-pushed
the
Darwin_BaseCHIPCluster
branch
from
f5cd129 to
df52cb7
Compare
vivien-apple
force-pushed
the
Darwin_BaseCHIPCluster
branch
from
df52cb7 to
57cbdff
Compare
mspang
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is the first part of some PRs to update the Objc API.
The ZAP templates changes are separated to the ZAP generation in terms of commits in order make it easier for the reviewer to not have to search for what has really been changed.
Summary of Changes
CHIPClusterbase class for Objc Clusters(void)in instead of(BOOL)and pass an error in thecompletionHandlerif something fails