Disable ZLL OnOff specific commands in bridge-app.zap #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Feb 16, 2021
…nning ./gn_build.sh
#### Problem project-chip#4858 has updated some `.zap` files since a ZAP submodule update has made some unwanted changes to the generated content. Sadly by *saving* the `bridge-app.zap` file to disk some ZLL specific commands for the On/Off cluster got enabled... While there is some code to handle those ZLL commands in the tree (under `src/app/clusters/zll-on-off-server`) it has not been yet updated to compile. So one can't *just* add it to `examples/bridge-app/bridge-common/BUILD.gn`. The simpler fix as the moment, is to revert back the `.zap` file with those commands disabled. #### Summary of changes * Add `bridge-app` to the list of apps built by default with the `gn_build.sh` script. So it will be easy to spot this kind of issue next time * Remove the 3 ZLL On/Off commands from the `bridge-app.zap` config file
vivien-apple
force-pushed
the
ZAP_ZLLBridgeApp
branch
from
2941690 to
276d0e0
Compare
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang and
saurabhst
saurabhst
approved these changes
Feb 16, 2021
saurabhst
approved these changes
Feb 16, 2021
andy31415
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of changes