Update EFR32 SDK from 2.7 to 3.1 #4870
Conversation
jepenven-silabs
requested review from
mspang,
andy31415,
saurabhst,
hawk248,
BroderickCarlin and
woody-apple
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo and
jelderton
jepenven-silabs
force-pushed
the
gsdk_update_3_1
branch
from
d74bf86 to
545de63
Compare
| @@ -564,61 +592,81 @@ CHIP_ERROR BLEManagerImpl::ConfigureAdvertisingData(void) | |||
| snprintf(mDeviceName, sizeof(mDeviceName), "%s%04" PRIX32, CHIP_DEVICE_CONFIG_BLE_DEVICE_NAME_PREFIX, (uint32_t) 0); | |||
|
|
|||
| mDeviceName[kMaxDeviceNameLength] = 0; | |||
| mDeviceNameLength = strlen(mDeviceName); | |||
There was a problem hiding this comment.
I guess we can do that, though we could also just use the return value of snprintf to compute this...
There was a problem hiding this comment.
@bzbarsky-apple true, we're planning to optimize our example in the next few days so this will likely get fix.
|
@woody-apple or @mspang any idea why Cirque is failing ? I tried looking at the logs but didn't find anything related to my PR in it.. |
|
Cirque is failing because OT updated the naming of binary output folder @jepenven-silabs maybe good to take in here as well ? |
|
@woody-apple , @mspang, @bzbarsky-apple merge ? |
Problem
Cannot update the OpenThread submodule in Chip because EFR32 CI job fails. This is because of the API used in CHIP are older than the one used in OpenThread.
Summary of Changes
Update EFR32 sdk used in CHIP to latest version for future OpenThread update
Fixes #4527
Fixes #4278
Fixes #2596
Fixes #2595
For update :
@tima-q @doru91