-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Media Playback Cluster #4848
Merged
andy31415
merged 1 commit into
project-chip:master
from
lazarkov:feature/media-playback-cluster
Feb 17, 2021
Merged
Add Media Playback Cluster #4848
andy31415
merged 1 commit into
project-chip:master
from
lazarkov:feature/media-playback-cluster
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazarkov
force-pushed
the
feature/media-playback-cluster
branch
3 times, most recently
from
February 15, 2021 16:17
ec2c541
to
5cf938f
Compare
lazarkov
force-pushed
the
feature/media-playback-cluster
branch
from
February 15, 2021 16:23
5cf938f
to
b81f31f
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
saurabhst and
woody-apple
February 15, 2021 19:15
msandstedt
approved these changes
Feb 15, 2021
lazarkov
force-pushed
the
feature/media-playback-cluster
branch
from
February 16, 2021 17:30
b81f31f
to
fb127a2
Compare
lazarkov
force-pushed
the
feature/media-playback-cluster
branch
3 times, most recently
from
February 17, 2021 11:01
0503b38
to
487dc99
Compare
Problem We do not have media playback cluster which is needed for Chip to control media on TV Summary of Changes - Added Media Playback cluster.xml file - Added Media Playback client and server.cpp files - Updated example chip-tool so you can use media playback cluster - Created example tv-app so you can start a TV server
lazarkov
force-pushed
the
feature/media-playback-cluster
branch
from
February 17, 2021 11:25
487dc99
to
d4a45e7
Compare
Size increase report for "esp32-example-build" from 6a41524
Full report output
|
woody-apple
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jelderton
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not support media functionality (play, pause, rewind etc.) on project-chip. We need to have a media playback cluster to be able to cover these commands.
Summary of Changes
This is boilerplate code. There will be follow up with logic update of the cluster.
Documentation
Test
./scripts/tools/zap_regen_all.py
and./gn_build.sh
to verify the building is successful