Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Media Playback Cluster #4848

Merged

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Feb 12, 2021

Problem

We do not support media functionality (play, pause, rewind etc.) on project-chip. We need to have a media playback cluster to be able to cover these commands.

Summary of Changes

This is boilerplate code. There will be follow up with logic update of the cluster.

  • Added Media Playback cluster.xml file
  • Added Media Playback client and server.cpp files
  • Updated example chip-tool so you can use media playback cluster
  • Created example tv-app so you can start a TV server

Documentation

  • You can see the media playback cluster specification in this URL

Test

  • Tested locally using chip-tool client and newly created tv-server
  • Used the ./scripts/tools/zap_regen_all.py and ./gn_build.sh to verify the building is successful

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2021

CLA assistant check
All committers have signed the CLA.

@lazarkov lazarkov force-pushed the feature/media-playback-cluster branch 3 times, most recently from ec2c541 to 5cf938f Compare February 15, 2021 16:17
@lazarkov lazarkov force-pushed the feature/media-playback-cluster branch from 5cf938f to b81f31f Compare February 15, 2021 16:23
@lazarkov lazarkov force-pushed the feature/media-playback-cluster branch from b81f31f to fb127a2 Compare February 16, 2021 17:30
@lazarkov lazarkov force-pushed the feature/media-playback-cluster branch 3 times, most recently from 0503b38 to 487dc99 Compare February 17, 2021 11:01
Problem
We do not have media playback cluster which is needed for Chip to control media on TV

Summary of Changes
- Added Media Playback cluster.xml file
- Added Media Playback client and server.cpp files
- Updated example chip-tool so you can use media playback cluster
- Created example tv-app so you can start a TV server
@lazarkov lazarkov force-pushed the feature/media-playback-cluster branch from 487dc99 to d4a45e7 Compare February 17, 2021 11:25
@github-actions
Copy link

Size increase report for "esp32-example-build" from 6a41524

File Section File VM
chip-all-clusters-app.elf .flash.text 360 360
chip-all-clusters-app.elf .flash.rodata 88 88
chip-all-clusters-app.elf .dram0.bss 0 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,21796
.debug_line,0,9673
.debug_loc,0,5885
.debug_str,0,2775
.debug_abbrev,0,1119
.strtab,0,699
.debug_frame,0,616
.flash.text,360,360
.symtab,0,208
.debug_ranges,0,160
.debug_aranges,0,144
.flash.rodata,88,88
.dram0.bss,8,0
.shstrtab,0,1
[Unmapped],0,-88


Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy31415 andy31415 merged commit e1d4664 into project-chip:master Feb 17, 2021
@lazarkov lazarkov deleted the feature/media-playback-cluster branch December 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants