-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Optimize the temperature-measurement-app to use less RAM and Flash. #4756
ESP32: Optimize the temperature-measurement-app to use less RAM and Flash. #4756
Conversation
2c5cf28
to
27d56ba
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't disable assertions for CHIP developers. We should separate optimized, release appropriate setting from those suitable for development.
Hi @mspang I thought of demonstrating all possible optimizations in the |
We have such a setting for other apps, it's called "is_debug". ESP32 should have similar. Debug should be the default. |
cd26f9c
to
dff818a
Compare
c9e446b
to
3ebd4d7
Compare
Hi @mspang, PR is ready as per the changes mentioned. |
3ebd4d7
to
2291cd4
Compare
04bdadf
to
ddf8299
Compare
ddf8299
to
9d80124
Compare
9d80124
to
b40d727
Compare
Can the relevant folks please take a look and merge if it looks okay. Thanks! |
Problem
Need to optimize the temperature-measurement-app to use less RAM and Flash.
Summary of Changes
a) Added the optimization in the sdkconfig for
1. Wi-Fi and BLE
2. Disable asserts.
3. FreeRTOS unicore mode
Footprint values are as below
Default without optimization
Free Heap :- 169012 bytes
Optimization with new sdkconfig.defaults
It includes:-
Free Heap: 196004 bytes
Optimization with 'is_debug = false'
It includes the above optimization along with the following
Free Heap :- 196748 bytes
b) Chose NimBLE as a default BT host for CI sdkconfig.
Fixes #3977