Use Default Critical (Non-Critical) Marks for CHIP Cert Extensions. #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following certificate extensions, when present, MUST be marked as critical: - basic constraints extension - key usage extension - extended key usage extension The following certificate extensions, when present, MUST be marked as non-critical: - subject key identifier extension - authority key identifier extension These rules should always be enforced when processing X.509 representation of the certificate. In the CHIP certificate representation the "critical" field is omitted. Ticket: project-chip#4708
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst and
woody-apple
andy31415
approved these changes
Feb 8, 2021
bzbarsky-apple
approved these changes
Feb 8, 2021
Co-authored-by: Boris Zbarsky <[email protected]>
mspang
approved these changes
Feb 8, 2021
woody-apple
approved these changes
Feb 10, 2021
saurabhst
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following certificate extensions, when present, MUST be marked as critical:
The following certificate extensions, when present, MUST be marked as non-critical:
These rules should always be enforced when processing X.509 representation of the certificate.
In the CHIP certificate representation the "critical" field is omitted.
Ticket: #4708