Be more consistent about construction/destruction of ChipCertificateData #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst and
woody-apple
saurabhst
approved these changes
Feb 5, 2021
woody-apple
approved these changes
Feb 5, 2021
andy31415
approved these changes
Feb 5, 2021
|
I do find this a bit awkward because it accepts that the destructor can run multiple times on the same object (we do not seem to check for any 'is constructed already' flag. Maybe we should specifically document this requirement. |
…ata. We are mixing placement new with Clear() calls and no destructor calls, and in some cases (ChipCertificateSet::Release) doing neither clearing nor destruction. Instead, try to consistently use ~ChipCertificateData when we are no longer keeping track of the relevant object. The addition of `Clear()` in `~ChipCertificateData` is both to match existing behavior and on the assumption that we don't want that data lying around in memory if not needed.
bzbarsky-apple
force-pushed
the
fix-cert-data-dtors
branch
from
f0889aa to
39c9195
Compare
|
I added a comment on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are mixing placement new with Clear() calls and no destructor
calls, and in some cases (ChipCertificateSet::Release) doing neither
clearing nor destruction. Instead, try to consistently use
~ChipCertificateData when we are no longer keeping track of the
relevant object.
The addition of
Clear()in~ChipCertificateDatais both to matchexisting behavior and on the assumption that we don't want that data
lying around in memory if not needed.
Problem
See commit message.
Summary of Changes
See commit message.
Fixes #4688