Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Pigweed-app example on EFR32 #4630

Merged
merged 8 commits into from
Feb 8, 2021

Conversation

jmartinez-silabs
Copy link
Member

Problem

Need of a Pigweed rcp example on EFR32 platforms

Summary of Changes

  • Create the example at example/pigweed-app/efr32/
  • Init uart driver and create function to read and write a character
  • link those functions with pigweed backend pw_sys_io
  • create GN build structure for pigweed usage with EFR32 platform
  • move some files that can be shared for all EFR32 examples to efr32/platform
  • Readme on how to build and run the pigweed-app

config/efr32/BUILD.gn Outdated Show resolved Hide resolved
examples/pigweed-app/efr32/BUILD.gn Outdated Show resolved Hide resolved
Copy link
Contributor

@szatmz szatmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please file an issue to move the SDK/platform logging from RTT over to pw_logs whenever pw_rpc is enabled. THank you!

config/efr32/BUILD.gn Outdated Show resolved Hide resolved
config/efr32/lib/pw_rpc/BUILD.gn Outdated Show resolved Hide resolved
examples/lighting-app/efr32/args.gni Outdated Show resolved Hide resolved
jmartinez-silabs and others added 6 commits February 5, 2021 13:29
- Init uart driver and create function to read and write a character
- link those  functions with pigweed backend
- move some files that can be shared for all EFR32 examples to efr32/platform
- create GN build structure for pigweed usage with EFR32 platform

Implement the Pigweed-app example on EFR32
- Init uart driver and create function to read and write a character
- link those  functions with pigweed backend
- move some files that can be shared for all EFR32 examples to efr32/platform
- create GN build structure for pigweed usage with EFR32 platform

Change uart driver from uartdrv to retargetSerial, using the dma was causing issues reading with pigweed proto
Cleanup in the build GN files

Some cleanup for the build
Change copyright to 2021 for new files
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending @mspang 's feedback

…e for all examples. That config is only used when pw_rpc is build

Create a with_pw_rpc.gni file in efr examples. This gni file need to be imported in the build args when we will want to build a example with pw_rpc (this is still a WIP)

This doesn't impact pigweed-app example because it always runs the pw_rpc
@jmartinez-silabs
Copy link
Member Author

@woody-apple @andy31415 @mspang Can this be Merged?

@mspang mspang merged commit f295f98 into project-chip:master Feb 8, 2021
@jmartinez-silabs jmartinez-silabs deleted the pw-efr branch February 24, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants