Update ZCL reporting code to be compatible with a client ZAP application #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem In project-chip#3608, many reporting specific callbacks has been moved from `gen/callback-stub.cpp` to `src/app/reporting/`. The PR has been a bit overzealous since all the `*ReportingResponseCallback` declarations and definitions has been moved while those still needs to be part of the `gen/` content if one wants to override them. Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter. Those issues prevents to write a client application that consumes a `.zap` configuration file. #### Summary of changes * Move back `*ReportingResponseCallback` to the `gen/` folder * Update the `#ifdef` in `src/app/server/DataModelHandler.cpp` to only call the stack status callbacks for the server side * Update `HandleDataModelMessage` signature by only passing a `NodeId` for the first argument and remove the last one which is unused.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst,
wehale and
woody-apple
woody-apple
approved these changes
Feb 2, 2021
andy31415
approved these changes
Feb 3, 2021
saurabhst
approved these changes
Feb 3, 2021
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…ion (project-chip#4604) #### Problem In project-chip#3608, many reporting specific callbacks has been moved from `gen/callback-stub.cpp` to `src/app/reporting/`. The PR has been a bit overzealous since all the `*ReportingResponseCallback` declarations and definitions has been moved while those still needs to be part of the `gen/` content if one wants to override them. Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter. Those issues prevents to write a client application that consumes a `.zap` configuration file. #### Summary of changes * Move back `*ReportingResponseCallback` to the `gen/` folder * Update the `#ifdef` in `src/app/server/DataModelHandler.cpp` to only call the stack status callbacks for the server side * Update `HandleDataModelMessage` signature by only passing a `NodeId` for the first argument and remove the last one which is unused.
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…ion (project-chip#4604) #### Problem In project-chip#3608, many reporting specific callbacks has been moved from `gen/callback-stub.cpp` to `src/app/reporting/`. The PR has been a bit overzealous since all the `*ReportingResponseCallback` declarations and definitions has been moved while those still needs to be part of the `gen/` content if one wants to override them. Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter. Those issues prevents to write a client application that consumes a `.zap` configuration file. #### Summary of changes * Move back `*ReportingResponseCallback` to the `gen/` folder * Update the `#ifdef` in `src/app/server/DataModelHandler.cpp` to only call the stack status callbacks for the server side * Update `HandleDataModelMessage` signature by only passing a `NodeId` for the first argument and remove the last one which is unused.
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…ion (project-chip#4604) #### Problem In project-chip#3608, many reporting specific callbacks has been moved from `gen/callback-stub.cpp` to `src/app/reporting/`. The PR has been a bit overzealous since all the `*ReportingResponseCallback` declarations and definitions has been moved while those still needs to be part of the `gen/` content if one wants to override them. Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter. Those issues prevents to write a client application that consumes a `.zap` configuration file. #### Summary of changes * Move back `*ReportingResponseCallback` to the `gen/` folder * Update the `#ifdef` in `src/app/server/DataModelHandler.cpp` to only call the stack status callbacks for the server side * Update `HandleDataModelMessage` signature by only passing a `NodeId` for the first argument and remove the last one which is unused.
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
…ion (project-chip#4604) #### Problem In project-chip#3608, many reporting specific callbacks has been moved from `gen/callback-stub.cpp` to `src/app/reporting/`. The PR has been a bit overzealous since all the `*ReportingResponseCallback` declarations and definitions has been moved while those still needs to be part of the `gen/` content if one wants to override them. Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter. Those issues prevents to write a client application that consumes a `.zap` configuration file. #### Summary of changes * Move back `*ReportingResponseCallback` to the `gen/` folder * Update the `#ifdef` in `src/app/server/DataModelHandler.cpp` to only call the stack status callbacks for the server side * Update `HandleDataModelMessage` signature by only passing a `NodeId` for the first argument and remove the last one which is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #3608, many reporting specific callbacks has been moved from
gen/callback-stub.cpptosrc/app/reporting/. The PR has been a bit overzealous since all the*ReportingResponseCallbackdeclarations and definitions has been moved while those still needs to be part of thegen/content if one wants to override them.Also, the server specific stack status callbacks are called for both the client and the server, while those only needs to be called by the reporter.
Those issues prevents to write a client application that consumes a
.zapconfiguration file.Summary of changes
*ReportingResponseCallbackto thegen/folder#ifdefinsrc/app/server/DataModelHandler.cppto only call the stack status callbacks for the server sideHandleDataModelMessagesignature by only passing aNodeIdfor the first argument and remove the last one which is unused.