Update chip-tool listening port to be 'CHIP_PORT + 1' instead of CHIP… #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_PORT #### Problem `chip-tool` is sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port `11097` (`CHIP_TOOL`). It is easy to workaround this by adding a `ListenPort=11098` to `/tmp/chip_tool_config.ini` but it requires an extra step that is not necessary. #### Summary of changes * Listen on port `CHIP_PORT + 1` by default instead of `CHIP_PORT`
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst and
woody-apple
|
Should we add a command-line argument instead? Although we are loking to deprecate chip tool, so maybe either approach works just as well. |
andy31415
approved these changes
Feb 1, 2021
At some point I should probably rewrite the command line parsing ability of
On a side note it's possible that |
saurabhst
approved these changes
Feb 2, 2021
woody-apple
approved these changes
Feb 2, 2021
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…_PORT (project-chip#4590) #### Problem `chip-tool` is sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port `11097` (`CHIP_TOOL`). It is easy to workaround this by adding a `ListenPort=11098` to `/tmp/chip_tool_config.ini` but it requires an extra step that is not necessary. #### Summary of changes * Listen on port `CHIP_PORT + 1` by default instead of `CHIP_PORT`
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…_PORT (project-chip#4590) #### Problem `chip-tool` is sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port `11097` (`CHIP_TOOL`). It is easy to workaround this by adding a `ListenPort=11098` to `/tmp/chip_tool_config.ini` but it requires an extra step that is not necessary. #### Summary of changes * Listen on port `CHIP_PORT + 1` by default instead of `CHIP_PORT`
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
…_PORT (project-chip#4590) #### Problem `chip-tool` is sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port `11097` (`CHIP_TOOL`). It is easy to workaround this by adding a `ListenPort=11098` to `/tmp/chip_tool_config.ini` but it requires an extra step that is not necessary. #### Summary of changes * Listen on port `CHIP_PORT + 1` by default instead of `CHIP_PORT`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_PORT
Problem
chip-toolis sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port11097(CHIP_TOOL).It is easy to workaround this by adding a
ListenPort=11098to/tmp/chip_tool_config.inibut it requires an extra step that is not necessary.Summary of changes
CHIP_PORT + 1by default instead ofCHIP_PORT