[.github/workflows] Added pigweed-app related builds to workflows.

[kkasperczyk-no]

Problem

There is no build validation in CI for pigweed-app, as this app related builds are not ran in the github workflows.

Summary of Changes

• Modified nrfconnect_example.sh to take board name as an mandatory argument and also allow passing list of additional arguments (e.g. attaching overlays).
• Added pigweed-app build and lighting-app with rpc.overlay build to the nrfconnect github workflows.
• Renamed esp_echo_app.sh to the esp_example.sh and modified it to take application name as an argument.
• Added pigweed-app build to the esp32 github workflow.
• Renamed Echo App build step to the All Clusters App in the esp32 and qemu github workflows, as in fact that app is being build.

Fixes #4562

[szatmz]

Awesome, thank you!

[szatmz]

isn't running bootstrap.sh enough?

[kkasperczyk-no]

I think not for pigweed-app, as activate.sh sets proper python version. Without running activate.sh python version is set wrong (I guess it is 2.7 ?) and when compiling pigweed syntax errors appear.

[szatmz]

Well, that's weird given that activate.sh is a symlink to bootstrap.sh:

$ ll ./scripts/activate.sh 
lrwxrwxrwx 1 szatmz primarygroup 12 Nov  2 17:48 ./scripts/activate.sh -> bootstrap.sh

[woody-apple]

@kkasperczyk-no can you take a peek at this? Sounds like something isn't working as expected..

[LuDuda]

Thanks 👍 few comments below.

[woody-apple]

@kkasperczyk-no Note: build fails :(

[kkasperczyk-no]

@kkasperczyk-no Note: build fails :(

Yes I know and it also fails for me locally, but I'm not sure if it is related to my change or the pigweed-app for ESP32 build doesn't work and now I added it to CI, so I triggered fail. I contacted with Zoltan, so I have a hope to get some help with that.

[szatmz]

https://github.com/project-chip/connectedhomeip/pull/4563/files#diff-470dd5fd8deeed802cd57c2e1d4b0aa41289828b479df1bdfd1cde5cd75c4a48R41 'all-clusters-app' needs replaced with '"$root"', no?

[szatmz]

Regarding the ESP32 build breakage:

The problem is that esp_example.sh uses two sdkconfig defaults to seed the sdkconfig for the build: sdkconfig_devkit.defaults and sdkconfig_m5stack.defaults. The directory examples/pigweed-app/esp32 has neither.
The esp_example.sh script should be refactored. It should look for all the sdkconfig*.defaults files and run the build for all of those that actually exist in a particular example app's directory.
Please add this refactoring to your PR. Many thanks in advance!

[kkasperczyk-no]

Regarding the ESP32 build breakage:

The problem is that esp_example.sh uses two sdkconfig defaults to seed the sdkconfig for the build: sdkconfig_devkit.defaults and sdkconfig_m5stack.defaults. The directory examples/pigweed-app/esp32 has neither.
The esp_example.sh script should be refactored. It should look for all the sdkconfig*.defaults files and run the build for all of those that actually exist in a particular example app's directory.
Please add this refactoring to your PR. Many thanks in advance!

@szatmz now it's working, but I had to change several things, so please verify if you are ok with them:

• Added for loop building all sdkconfig*.defaults present in the given app directory
• Added running activate.sh before building to prevent pigweed-app from failing because of the incorrect python version
• Changed target name for the esp32 pigweed-app from pw-rpc-app to chip-pigweed-app to be consistent with chip-all-clusters-app.
• Changed a bit names of output .elf files generated when building sdkconfig.defaults, as it was hard to parametrize it (now it is sdkconfig_devkit-chip-all-clusters-app.elf, sdkconfig_m5stack-chip-all-clusters-app.elf and sdkconfig-chip-all-clusters-app.elf)

[szatmz]

This looks good to me now, and apparently the build checks are passing too. Thank you Kamil for your work on this. The need to call 'activate.sh' is peculiar, I will ask Pigweed devs about it. Nevertheless that shouldn't hold this PR back from merging.