Device layer generic code #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
robszewczyk,
tpmanley and
woody-apple
as code owners
| kEventTypeNotSet = kRange_Internal, | ||
| kNoOp, | ||
| kCallWorkFunct, | ||
| kchipSystemLayerEvent, |
There was a problem hiding this comment.
nit: kChipSystemLayerEvent
There was a problem hiding this comment.
@BroderickCarlin latest commit should fix this, and some more.
woody-apple
approved these changes
Mar 12, 2020
|
@gerickson or @BroderickCarlin Thoughts? |
gerickson
reviewed
Mar 12, 2020
| * The name of the chip task. | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_CHIP_TASK_NAME | ||
| #define CHIP_DEVICE_CONFIG_CHIP_TASK_NAME "WEAVE" |
There was a problem hiding this comment.
Thanks @gerickson , fixed it now
gerickson
reviewed
Mar 12, 2020
| * chip Software Update service. | ||
| * | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_SOFTWARE_UPDATE_RESPOSNE_TIMEOUT |
gerickson
reviewed
Mar 12, 2020
| * | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_SOFTWARE_UPDATE_RESPOSNE_TIMEOUT | ||
| #define CHIP_DEVICE_CONFIG_SOFTWARE_UPDATE_RESPOSNE_TIMEOUT 10000 |
gerickson
reviewed
Mar 12, 2020
| * chip File Download service. | ||
| * | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_FILE_DOWNLOAD_RESPOSNE_TIMEOUT |
gerickson
reviewed
Mar 12, 2020
| * | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_FILE_DOWNLOAD_RESPOSNE_TIMEOUT | ||
| #define CHIP_DEVICE_CONFIG_FILE_DOWNLOAD_RESPOSNE_TIMEOUT 10000 |
gerickson
approved these changes
Mar 12, 2020
fkjagodzinski
pushed a commit
to fkjagodzinski/connectedhomeip
that referenced
this pull request
Feb 16, 2021
Add mbed implementation for SystemTimeSupport.cpp
jmartinez-silabs
referenced
this pull request
in SiliconLabs/matter
Aug 18, 2022
…#21920) Merge in WMN_TOOLS/matter from fix_psa_err-139 to silabs Squashed commit of the following: commit 8514ea0275dce67c7ed0d8284b7def687666cf67 Author: Ricardo Casallas <[email protected]> Date: Tue Aug 16 16:00:48 2022 -0400 [EFR32] Destroy PSA key_id if exists. (project-chip#21920) * [EFR32] Recover from PSA keygen error. * [EFR32] Destroy existing PSA key_id before re-using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import device layer generic code for the following components