-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thread] Allow to specify dataset timestamp #4410
Merged
rwalker-apple
merged 2 commits into
project-chip:master
from
Damian-Nordic:thread-timestamp
Jan 19, 2021
Merged
[thread] Allow to specify dataset timestamp #4410
rwalker-apple
merged 2 commits into
project-chip:master
from
Damian-Nordic:thread-timestamp
Jan 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
January 19, 2021 08:59
Size increase report for "esp32-example-build" from 4bbe313
Full report output
|
Size increase report for "nrfconnect-example-build" from 4bbe313
Full report output
|
saurabhst
approved these changes
Jan 19, 2021
andy31415
approved these changes
Jan 19, 2021
rwalker-apple
approved these changes
Jan 19, 2021
saurabhst
approved these changes
Jan 19, 2021
jepenven-silabs
pushed a commit
to jepenven-silabs/connectedhomeip
that referenced
this pull request
Jan 21, 2021
* [thread] Allow to specify dataset timestamp * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
4008 removed setting Thread Dataset Active Timestamp to make sure that a provisioned device collects missing Thread settings from a border router. The problem is it may be too restrictive, since it's now impossible to start the device as a Thread leader as the leader role requires that the timestamp be initialized.
Summary of Changes