Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread] Allow to specify dataset timestamp #4410

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

4008 removed setting Thread Dataset Active Timestamp to make sure that a provisioned device collects missing Thread settings from a border router. The problem is it may be too restrictive, since it's now impossible to start the device as a Thread leader as the leader role requires that the timestamp be initialized.

Summary of Changes

  • Extend the DeviceNetworkInfo structure to allow to specify the Thread Dataset Active Timestamp.
  • Slightly optimize the structure size.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 4bbe313

File Section File VM
chip-all-clusters-app.elf .flash.text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,70
.debug_str,0,23
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,1
.debug_loc,0,-2
.flash.text,-4,-4


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 4bbe313

File Section File VM
chip-lighting.elf shell_root_cmds_sections 8 8
chip-lighting.elf text 8 8
chip-lock.elf shell_root_cmds_sections 8 8
chip-lock.elf text 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,88
.debug_loc,0,25
.debug_str,0,23
shell_root_cmds_sections,8,8
text,8,8
.debug_line,0,-8
.debug_ranges,0,-8

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,88
.debug_loc,0,25
.debug_str,0,23
shell_root_cmds_sections,8,8
text,8,8
.debug_line,0,-8
.debug_ranges,0,-8

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_str,0,23
.debug_info,0,16
.debug_loc,0,13
.debug_line,0,12


@pullapprove pullapprove bot requested a review from saurabhst January 19, 2021 13:42
@rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple merged commit b9e09f0 into project-chip:master Jan 19, 2021
jepenven-silabs pushed a commit to jepenven-silabs/connectedhomeip that referenced this pull request Jan 21, 2021
* [thread] Allow to specify dataset timestamp

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants