Remove 'postCreateCommand' for vsenv docker. #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command fails on my machine - unclear as to why, however running sudo commands as part of the devcontainer setup does not sound right. I would rather keep my existing docker setup and permissions.
pullapprove
bot
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang and
saurabhst
mspang
approved these changes
Jan 18, 2021
saurabhst
approved these changes
Jan 19, 2021
rwalker-apple
approved these changes
Jan 19, 2021
jepenven-silabs
pushed a commit
to jepenven-silabs/connectedhomeip
that referenced
this pull request
Jan 21, 2021
This command fails on my machine - unclear as to why, however running sudo commands as part of the devcontainer setup does not sound right. I would rather keep my existing docker setup and permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Post-vscode container build always fails on my machine.
Summary of Changes
Running sudo commands as part of the container build seems wrong. Removed the entire post command.