Add custom types to chip ZCL inside src/app/zap-templates/zcl #4348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some custom types to CHIP ZCL in order to sync generated files and the values from
src/app/util/basic-types.h
This PR comes from a comment: #4329 (comment)
The custom types lives inside their own XML files in
src/app/zap-templates/custom-types.xml
. Some of the JS helpers have been updated to take into accounts those new types and to have a single source of trust in `src/app/zap-templates/common/ChipTypesHelper.js'.Lastly the content of the
gen/
folders has been updated to reflect those changes.The changes to
gen/attribute-id.h
andgen/enums.h
are unrelated to this PR and are likely a out of sync between the templates and the generated code.