Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom types to chip ZCL inside src/app/zap-templates/zcl #4348

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

vivien-apple
Copy link
Contributor

This PR adds some custom types to CHIP ZCL in order to sync generated files and the values from src/app/util/basic-types.h

This PR comes from a comment: #4329 (comment)

The custom types lives inside their own XML files in src/app/zap-templates/custom-types.xml. Some of the JS helpers have been updated to take into accounts those new types and to have a single source of trust in `src/app/zap-templates/common/ChipTypesHelper.js'.

Lastly the content of the gen/ folders has been updated to reflect those changes.

The changes to gen/attribute-id.h and gen/enums.h are unrelated to this PR and are likely a out of sync between the templates and the generated code.

This PR adds some custom types to CHIP ZCL in order to sync generated files and the values from `src/app/util/basic-types.h`
The custom types lives inside their own XML files in `src/app/zap-templates/custom-types.xml`. Some of the JS helpers have been updated to take into accounts those new types and to have a single source of trust in `src/app/zap-templates/common/ChipTypesHelper.js'.

Lastly the content of the `gen/` folders has been updated to reflect those changes.
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from ab9dda6

File Section File VM
chip-lighting.elf rodata 8 8
chip-lock.elf rodata 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,192
.debug_str,0,116
rodata,8,8
.debug_loc,0,4

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,168
.debug_str,0,116
rodata,8,8
.debug_loc,0,-4

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build" from ab9dda6

File Section File VM
chip-all-clusters-app.elf .flash.rodata 8 8
chip-all-clusters-app.elf .flash.text 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,384
.debug_str,0,110
.flash.rodata,8,8
.flash.text,4,4
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-2
.debug_loc,0,-4
[Unmapped],0,-8


@rwalker-apple rwalker-apple merged commit 8efa9a7 into project-chip:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants