-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFC Tag Reading support added #4331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3626 |
Could you fill in the summary template? |
rwalker-apple
force-pushed
the
sazria/nfctool
branch
from
January 14, 2021 22:18
29302ee
to
c5fe319
Compare
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple,
saurabhst and
vivien-apple
January 14, 2021 23:03
Size increase report for "esp32-example-build" from 2c820d0
Full report output
|
Size increase report for "nrfconnect-example-build" from 2c820d0
Full report output
|
rwalker-apple
approved these changes
Jan 15, 2021
@shana-apple good job! I tested your code with nrfconnect platform using small workaround with replacing space with "-" in QR code payload (mentioned by you in the code comment) and everything seems to work properly. |
kkasperczyk-no
approved these changes
Jan 18, 2021
saurabhst
approved these changes
Jan 19, 2021
jelderton
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no support for NFC tag reading as of yet in the iOS demo app
Summary of Changes
This change adds UI to the iOS app to scan an NFC tag and then follows the same flow as that of QR code reading.
Caveat:
Fixes #3626