Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC Tag Reading support added #4331

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Conversation

shana-apple
Copy link
Contributor

@shana-apple shana-apple commented Jan 12, 2021

Problem

There is no support for NFC tag reading as of yet in the iOS demo app

Summary of Changes

This change adds UI to the iOS app to scan an NFC tag and then follows the same flow as that of QR code reading.

Caveat:

  • This change is disabled by default because a paid developer account is required to have the NFC reading capability. See doc on how to enable this capability for flow to work

Fixes #3626

@franck-apple
Copy link

fixes #3626

@andy31415
Copy link
Contributor

Could you fill in the summary template?

@woody-apple
Copy link
Contributor

@shana-apple ?

@github-actions
Copy link

Size increase report for "esp32-example-build" from 2c820d0

File Section File VM
chip-all-clusters-app.elf .flash.text 1100 1100
chip-all-clusters-app.elf .flash.rodata 72 72
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,11600
.debug_str,0,3338
.debug_line,0,3011
.debug_loc,0,1893
.strtab,0,1382
.flash.text,1100,1100
.debug_ranges,0,600
.symtab,0,176
.debug_frame,0,168
.flash.rodata,72,72
.debug_aranges,0,56
.debug_abbrev,0,7
.shstrtab,0,2
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1
[Unmapped],0,-72


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 2c820d0

File Section File VM
chip-lighting.elf text 1008 1008
chip-lighting.elf rodata 72 72
chip-lock.elf text 1008 1008
chip-lock.elf rodata 72 76
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,8302
.debug_str,0,3338
.debug_loc,0,2486
.debug_line,0,1572
.strtab,0,1159
text,1008,1008
.debug_ranges,0,464
.symtab,0,400
.debug_frame,0,200
rodata,72,72
.debug_aranges,0,48
.shstrtab,0,1
.debug_abbrev,0,-2

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,8302
.debug_str,0,3338
.debug_loc,0,2490
.debug_line,0,1568
.strtab,0,1159
text,1008,1008
.debug_ranges,0,464
.symtab,0,400
.debug_frame,0,200
rodata,76,72
.debug_aranges,0,48
.shstrtab,0,1
.debug_abbrev,0,-2


@kkasperczyk-no
Copy link
Contributor

@shana-apple good job! I tested your code with nrfconnect platform using small workaround with replacing space with "-" in QR code payload (mentioned by you in the code comment) and everything seems to work properly.

@mspang mspang merged commit 8625463 into project-chip:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Darwin] Add support for reading NFC tag containing CHIP setup payload
9 participants