Update TestSystemPacketBuffer #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Uses of `PacketBuffer` have largely been replaced by `PacketBufferHandle`. The unit test had not kept up. #### Summary of Changes - Added tests for PacketBufferHandle specifically. - Added many checks of reference counts to verify the ownership model. - Some more refactoring into `PacketBufferTest`, friend class of `PacketBuffer` and `PacketBufferHandle`, to use private fields and track buffer allocations. part of project-chip#2707 - Figure out a way to express PacketBuffer ownership in the type system
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple,
sagar-apple and
saurabhst
rwalker-apple
approved these changes
Jan 11, 2021
mspang
approved these changes
Jan 12, 2021
andy31415
approved these changes
Jan 12, 2021
jelderton
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Uses of
PacketBufferhave largely been replaced byPacketBufferHandle. The unit test had not kept up.Summary of Changes
PacketBufferTest, friend class ofPacketBufferandPacketBufferHandle, to use private fields and track buffer allocations.part of #2707 - Figure out a way to express PacketBuffer ownership in the type system