Add support for "commisionable" discovery advertisement #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make sure multiple start calls work
…g, so mark esp verbosity to verbose
… we use the platform advertiser in this example
…for version, which seems unfortunate)
… Naming is a bit too close for comfort ...
|
|
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
|
This has the commits from #4200, right? Would you mind re-requesting review once that's landed and this PR is rebased so we can examine your changes in isolation? |
|
@arunbharadwaj - I believe #4200 has been merged and this should be ready for rebase/merge |
|
Created a new PR #4337 as there were too many merge conflicts after rebasing. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need support for "commisionable" discovery advertisement according to Discovery spec for CHIP
Summary of Changes
This adds support for "commisionable" discovery advertisement.
This builds on top of PR #4200 which adds "commisioning" and "operational" discovery advertisements
This adds the Advertise() function in lib/mdns/Advertiser_ImplMinimalMdns.cpp to advertise service as _chipd._udp while running in commisionable mode.
This also adds the class CommisionableAdvertisingParameters which additionally contains pairingInstr and pairingHint
Finally, this adds some test code in the example/minimal-mdns/advertiser.cpp to test this mode.