Use CHIPProjectConfig.h in examples/lighting-app/linux/main.cpp inste… #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of kDefaultSetupPinCode
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
bzbarsky-apple
approved these changes
Dec 14, 2020
mspang
approved these changes
Dec 15, 2020
rwalker-apple
approved these changes
Jan 5, 2021
jelderton
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ad of kDefaultSetupPinCode
Problem
Other examples uses
CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODEandCHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATORinstead of an hardcoded value in the source file and a random value.Summary of Changes
CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATORandCHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR