Roll python deps & add pigweed's #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
force-pushed
the
for-chip/roll-python-deps
branch
from
585a159 to
fb2bdcb
Compare
andy31415
approved these changes
Dec 11, 2020
This will help avoid issues like the one fixed by project-chip#4165, where a pip package used by pigweed updated underneath us and broke. These are gathered from install_requires in setup.py of packages we install. Currently we don't have a way to fail the build if there's an unpinned dep; they'll have to be found manually and added to requirements.in.
mspang
force-pushed
the
for-chip/roll-python-deps
branch
from
fb2bdcb to
6f6b8aa
Compare
pullapprove
bot
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
rwalker-apple and
saurabhst
bzbarsky-apple
approved these changes
Dec 12, 2020
saurabhst
approved these changes
Dec 15, 2020
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jan 8, 2021
This will help avoid issues like the one fixed by project-chip#4165, where a pip package used by pigweed updated underneath us and broke. These are gathered from install_requires in setup.py of packages we install. Currently we don't have a way to fail the build if there's an unpinned dep; they'll have to be found manually and added to requirements.in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help avoid issues like the one fixed by #4165, where a pip
package used by pigweed updated underneath us and broke.
These are gathered from install_requires in setup.py of packages we
install. Currently we don't have a way to fail the build if there's an
unpinned dep; they'll have to be found manually and added to
requirements.in.