Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Make CHIP devices advertise as operational devices via mDNS #4144

Closed
wants to merge 19 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Dec 9, 2020

A duplicate of #4132 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • whitespace

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

Size increase report for "nrfconnect-example-build" from dfd5015

File Section File VM
chip-lighting.elf text 6944 6944
chip-lighting.elf rodata 1272 1272
chip-lighting.elf bss 0 992
chip-lighting.elf init_array 8 8
chip-lighting.elf shell_root_cmds_sections -8 -8
chip-lock.elf text 6944 6944
chip-lock.elf rodata 1272 1272
chip-lock.elf bss 0 992
chip-lock.elf init_array 8 8
chip-lock.elf shell_root_cmds_sections 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,1749
.debug_line,0,385
.debug_loc,0,376
.debug_ranges,0,88
.debug_str,0,44
.debug_frame,0,36
.debug_abbrev,0,34
.debug_aranges,0,8

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,290347
.debug_line,0,50009
.debug_loc,0,32148
.debug_abbrev,0,30328
.debug_str,0,29328
.debug_ranges,0,13112
.strtab,0,9096
text,6944,6944
.symtab,0,5568
.debug_frame,0,3832
.debug_aranges,0,1320
rodata,1272,1272
bss,992,0
init_array,8,8
shell_root_cmds_sections,-8,-8

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,290379
.debug_line,0,50005
.debug_loc,0,32152
.debug_abbrev,0,30328
.debug_str,0,29328
.debug_ranges,0,13112
.strtab,0,9096
text,6944,6944
.symtab,0,5568
.debug_frame,0,3832
.debug_aranges,0,1320
rodata,1272,1272
bss,992,0
init_array,8,8
shell_root_cmds_sections,8,8


@restyled-io restyled-io bot closed this Dec 9, 2020
@restyled-io restyled-io bot deleted the restyled/pull-4132 branch December 9, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants