Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clusters sync gen folders #4115

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

vivien-apple
Copy link
Contributor

Problem

The examples gen/ folders has not been synced when #4006 has landed. It makes it harder to work on zap-templates since there are some unrelated changes.

Also this PR has updated src/app/zap-templates/helper-chip.js to use {{asUnderlyingZclType}} instead of {{asUnderlyingType}} into the js helper since this is what af-structs.zapt has started to use before #4006 lands. I assume this is a merge issue.

Summary of Changes

  • Sync the gen/ folder with ZAP templates
  • Update helper-chip.js to use the correct function

@vivien-apple
Copy link
Contributor Author

The CI issues should be resolved once #4114 lands.

@vivien-apple vivien-apple force-pushed the Clusters_SyncGenFolders branch from a716892 to b3a513f Compare December 8, 2020 14:51
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Size increase report for "esp32-example-build" from 9df28b5

File Section File VM
chip-all-clusters-app.elf .flash.text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,16,16
.debug_aranges,0,-8
.debug_ranges,0,-8
.debug_line,0,-124
.debug_loc,0,-130
.debug_frame,0,-144
.debug_abbrev,0,-187
.debug_info,0,-443
.debug_str,0,-704


@mspang mspang merged commit acfaa62 into project-chip:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants