MinMDNS refactor: support legacy replies and time throttling #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support legacy respones (include query in the response) - Some refactoring for better readability
pullapprove
bot
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
kpschoedel
approved these changes
Dec 7, 2020
rwalker-apple
approved these changes
Dec 7, 2020
saurabhst
approved these changes
Dec 8, 2020
mspang
approved these changes
Dec 8, 2020
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Dec 8, 2020
andy31415
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Convert mdns Builder classes to use PacketBufferHandle #### Problem Code should use `PacketBufferHandle` rather than `PacketBuffer` directly. #### Summary of Changes Convert mdns::Minimal::QueryBuilder and mdns::Minimal::ResponseBuilder to take and hold PacketBufferHandle. Part of issue #2707 - Figure out a way to express PacketBuffer ownership in the type system * Review: make QueryBuilder take const& * WIP * Revise to match ResponseBuilder in #4102 * Restyled by clang-format * remove PacketReporter.cpp change Co-authored-by: Restyled.io <[email protected]>
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jan 8, 2021
…4094) * Convert mdns Builder classes to use PacketBufferHandle #### Problem Code should use `PacketBufferHandle` rather than `PacketBuffer` directly. #### Summary of Changes Convert mdns::Minimal::QueryBuilder and mdns::Minimal::ResponseBuilder to take and hold PacketBufferHandle. Part of issue project-chip#2707 - Figure out a way to express PacketBuffer ownership in the type system * Review: make QueryBuilder take const& * WIP * Revise to match ResponseBuilder in project-chip#4102 * Restyled by clang-format * remove PacketReporter.cpp change Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
mDNS requires 'legacy replies' to include the original query in the response. This was not implemented in minMDNS.
Summary of Changes
Add support for: