[controller] Add IP rendezvous feature to CHIP Device controller #4050

erjiaqing · 2020-12-02T02:21:55Z

Problem

Basic IP rendezvous is supported on device side, however, when using chip-tool pairing softap:

± % ./out/chip-tool pairing softap 111 111 12345678 1383 fd12::2 11097
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 112233

CHIP:DL: Avahi connecting
CHIP:DL: CHIP task running
CHIP:DL: wpa_supplicant: connected to wpa_supplicant proxy
CHIP:DL: wpa_supplicant: can't find interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37645" (uid=699939 pid=2945875 comm="./out/chip-tool pairing softap 111 111 12345678 13") interface="fi.w1.wpa_supplicant1" member="GetInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")
CHIP:DL: wpa_supplicant: try to create interface wlan0
CHIP:DL: wpa_supplicant: failed to create interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37645" (uid=699939 pid=2945875 comm="./out/chip-tool pairing softap 111 111 12345678 13") interface="fi.w1.wpa_supplicant1" member="CreateInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")

It does not work.

Summary of Changes

Add necessary changes to chip device controller to make chip-tool pairing softap work
Add connect -ip command to python binding
Update cirque test to use IP rendezvous feature.

Testing

Tested w/ rpi running ubuntu 20.10 desktop.

± % ./out/chip-tool pairing softap 111 111 12345678 1383 fd12::2 11097
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 112233

CHIP:DL: wpa_supplicant: connected to wpa_supplicant proxy
CHIP:DL: Avahi connecting
CHIP:DL: CHIP task running
CHIP:DL: wpa_supplicant: can't find interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37647" (uid=699939 pid=2947087 comm="./out/chip-tool pairing softap 111 111 12345678 13") interface="fi.w1.wpa_supplicant1" member="GetInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")
CHIP:DL: wpa_supplicant: try to create interface wlan0
CHIP:DL: wpa_supplicant: failed to create interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37647" (uid=699939 pid=2947087 comm="./out/chip-tool pairing softap 111 111 12345678 13") interface="fi.w1.wpa_supplicant1" member="CreateInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")
CHIP:BLE: Received rendezvous message from 12344321
CHIP:CTL: Remote device completed SPAKE2+ handshake

CHIP:TOO: Secure Pairing Success
CHIP:TOO: Pairing Success
CHIP:CTL: Shutting down the commissioner
CHIP:CTL: Shutting down the controller

± % ./out/chip-tool onoff on 1
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 112233

CHIP:DL: wpa_supplicant: connected to wpa_supplicant proxy
CHIP:DL: wpa_supplicant: can't find interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37653" (uid=699939 pid=2947349 comm="./out/chip-tool onoff on 1 ") interface="fi.w1.wpa_supplicant1" member="GetInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")
CHIP:DL: wpa_supplicant: try to create interface wlan0
CHIP:DL: wpa_supplicant: failed to create interface wlan0: GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Rejected send message, 2 matched rules; type="method_call", sender=":1.37653" (uid=699939 pid=2947349 comm="./out/chip-tool onoff on 1 ") interface="fi.w1.wpa_supplicant1" member="CreateInterface" error name="(unset)" requested_reply="0" destination=":1.1" (uid=0 pid=1080 comm="/sbin/wpa_supplicant -u -s -O /run/wpa_supplicant ")
CHIP:DL: Avahi connecting
CHIP:DL: CHIP task running
CHIP:TOO: Endpoint id: '0x01', Cluster id: '0x0006', Command id: '0x01'
CHIP:ZCL: Successfully encoded 11 bytes
CHIP:DL: select failed: OS Error 2009 (0x000007D9): Bad file descriptor

CHIP:IN: New pairing for device 12344321, key 0!!
CHIP:IN: Sending msg from 112233 to 12344321
CHIP:IN: Secure transport transmitting msg 0 after encryption
CHIP:CTL: SendMessage returned 0
CHIP:TOO: OnMessage: Received 16 bytes
CHIP:TOO: APS frame processing success!
CHIP:TOO: DefaultResponse (0x0B):
CHIP:TOO:   commandId: 0x01
CHIP:TOO:   status: EMBER_ZCL_STATUS_SUCCESS (0x00)
CHIP:CTL: Shutting down the commissioner
CHIP:CTL: Shutting down the controller

± % chip-device-ctrl
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 112233

CHIP:DL: Avahi connecting
Chip Device Controller Shell

chip-device-ctrl > connect -ip fd12::2 12345678
Rendezvoud Complete
Connected
chip-device-ctrl > CHIP:BLE: Received rendezvous message from 12344321
CHIP:CTL: Remote device completed SPAKE2+ handshake


chip-device-ctrl >

After this PR, chip-device-ctrl can establish pase sessions, however, no traffic will use it, I will submit another pr for adding cluster support to chip device controller python binding. There are some special checks for BLE rendezvous, and they should be removed in the future after network provisioning cluster is ready.

Fixes #4038

src/controller/CHIPDeviceController.cpp

src/controller/python/chip/ChipDeviceCtrl.py

src/controller/CHIPDeviceController.cpp

andy31415 · 2020-12-02T16:55:38Z

src/controller/python/ChipDeviceController-ScriptBinding.cpp

@@ -530,10 +536,35 @@ void nl_Chip_DeviceController_SetLogFilter(uint8_t category)
 CHIP_ERROR nl_Chip_DeviceController_Connect(chip::DeviceController::ChipDeviceController * devCtrl, BLE_CONNECTION_OBJECT connObj,


unrelated question: why do we have a 'nl' prefix here? I am generally used to nl meaning 'nest labs' and then we can replace with just 'chip_DeviceController_connect' and similar and omit the nl prefix.

src/controller/python/ChipDeviceController-ScriptBinding.cpp

src/controller/python/ChipDeviceController-StorageDelegate.h

src/transport/RendezvousSession.cpp

erjiaqing · 2020-12-07T03:31:47Z

@andy31415 @rwalker-apple PTAL

src/controller/python/ChipDeviceController-StorageDelegate.h

src/controller/python/chip/ChipDeviceCtrl.py

rwalker-apple · 2020-12-07T20:38:07Z

@pan-apple?

github-actions · 2020-12-08T02:30:56Z

Size increase report for "esp32-example-build" from d2645f9

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	224	224
chip-all-clusters-app.elf	.dram0.bss	0	48
chip-all-clusters-app.elf	.flash.rodata	32	32

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,634
.debug_line,0,547
.debug_loc,0,256
.flash.text,224,224
.xt.prop._ZNK4chip20RendezvousParameters12IsControllerEv,0,128
.shstrtab,0,112
.dram0.bss,48,0
.strtab,0,48
.symtab,0,48
.flash.rodata,32,32
.debug_frame,0,24
.debug_str,0,24
.debug_aranges,0,8
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-3
.debug_ranges,0,-32
[Unmapped],0,-32
.debug_abbrev,0,-34

github-actions · 2020-12-08T02:31:09Z

Size increase report for "nrfconnect-example-build" from d2645f9

File	Section	File	VM
chip-lock.elf	text	232	232
chip-lock.elf	bss	0	51
chip-lock.elf	rodata	32	32
chip-lock.elf	shell_root_cmds_sections	8	8
chip-lock.elf	[LOAD #3 [RW]]	0	-19
chip-lighting.elf	text	228	228
chip-lighting.elf	bss	0	59
chip-lighting.elf	rodata	32	32
chip-lighting.elf	shell_root_cmds_sections	-4	-4
chip-lighting.elf	[LOAD #3 [RW]]	0	-27

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,525
.debug_line,0,309
text,232,232
.debug_loc,0,168
.debug_abbrev,0,74
.debug_frame,0,52
bss,51,0
.strtab,0,48
.symtab,0,48
rodata,32,32
.debug_str,0,24
.debug_aranges,0,8
shell_root_cmds_sections,8,8
[LOAD #3 [RW]],-19,0
.debug_ranges,0,-88

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,525
.debug_line,0,309
text,228,228
.debug_loc,0,176
.debug_abbrev,0,74
bss,59,0
.debug_frame,0,52
.strtab,0,48
.symtab,0,48
rodata,32,32
.debug_str,0,24
.debug_aranges,0,8
shell_root_cmds_sections,-4,-4
[LOAD #3 [RW]],-27,0
.debug_ranges,0,-88

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

src/controller/CHIPDeviceController.h

erjiaqing added 4 commits December 2, 2020 09:49

Add IP rendezvous to ChipDeviceController

615466a

Fix NodeId issue

d156140

Disable network provisioning for IP rendezvous

8cdb2ac

Update cirque tests

b5a9394

boring-cyborg bot added controller transport labels Dec 2, 2020

pullapprove bot requested review from andy31415, BroderickCarlin, bzbarsky-apple, chrisdecenzo, hawk248, jelderton, mspang, rwalker-apple and saurabhst December 2, 2020 02:22

Remove bypass_rendezvous flag for cirque tests

d6e1418

rwalker-apple reviewed Dec 2, 2020

View reviewed changes

src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved

Fix BLE rendezvous

b91fe57

erjiaqing force-pushed the issue_4038 branch from 07eb1ac to b91fe57 Compare December 2, 2020 03:37

Fix format issue

010cbc6

rwalker-apple reviewed Dec 2, 2020

View reviewed changes

src/controller/python/chip/ChipDeviceCtrl.py Outdated Show resolved Hide resolved

rwalker-apple mentioned this pull request Dec 2, 2020

python not checked by restyled.io #4051

Closed

Rollback most style changes in python scripts

1cb6bad

andy31415 reviewed Dec 2, 2020

View reviewed changes

yunhanw-google self-requested a review December 2, 2020 19:20

Address comments

da51b99

erjiaqing force-pushed the issue_4038 branch from 76afdb5 to da51b99 Compare December 3, 2020 03:54

erjiaqing requested review from rwalker-apple and andy31415 December 4, 2020 01:41

andy31415 approved these changes Dec 7, 2020

View reviewed changes

mspang requested review from pan-apple and vivien-apple December 7, 2020 19:46

mspang reviewed Dec 7, 2020

View reviewed changes

src/controller/python/ChipDeviceController-StorageDelegate.h Outdated Show resolved Hide resolved

src/controller/python/chip/ChipDeviceCtrl.py Outdated Show resolved Hide resolved

rwalker-apple approved these changes Dec 7, 2020

View reviewed changes

erjiaqing and others added 3 commits December 8, 2020 09:37

Merge remote-tracking branch 'chip/master' into issue_4038

aea8e46

Address comments

fe7185d

Restyled by clang-format

dfbe58a

restyled-io bot mentioned this pull request Dec 8, 2020

Restyle [controller] Add IP rendezvous feature to CHIP Device controller #4110

Closed

erjiaqing requested a review from mspang December 8, 2020 01:43

Add copyright header

3905f1b

mspang approved these changes Dec 8, 2020

View reviewed changes

erjiaqing added 2 commits December 8, 2020 13:09

Fix log in cirque test

2c1538b

Fix cirque test

5459a4f

boring-cyborg bot added the examples label Dec 8, 2020

vivien-apple reviewed Dec 8, 2020

View reviewed changes

src/controller/CHIPDeviceController.h Show resolved Hide resolved

Add todo for mIsIPRendezvous flag

c87550f

jelderton approved these changes Dec 9, 2020

View reviewed changes

andy31415 merged commit 830d1f8 into project-chip:master Dec 9, 2020

erjiaqing deleted the issue_4038 branch January 29, 2021 08:32

mspang mentioned this pull request Feb 25, 2021

python dev ctrl to support commissioning of Nodes already on the customer’s IP network #4235

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[controller] Add IP rendezvous feature to CHIP Device controller #4050

[controller] Add IP rendezvous feature to CHIP Device controller #4050

erjiaqing commented Dec 2, 2020 •

edited

Loading

andy31415 Dec 2, 2020

erjiaqing commented Dec 7, 2020

rwalker-apple commented Dec 7, 2020

github-actions bot commented Dec 8, 2020

github-actions bot commented Dec 8, 2020

		@@ -530,10 +536,35 @@ void nl_Chip_DeviceController_SetLogFilter(uint8_t category)
		CHIP_ERROR nl_Chip_DeviceController_Connect(chip::DeviceController::ChipDeviceController * devCtrl, BLE_CONNECTION_OBJECT connObj,

[controller] Add IP rendezvous feature to CHIP Device controller #4050

[controller] Add IP rendezvous feature to CHIP Device controller #4050

Conversation

erjiaqing commented Dec 2, 2020 • edited Loading

Problem

Summary of Changes

Testing

andy31415 Dec 2, 2020

Choose a reason for hiding this comment

erjiaqing commented Dec 7, 2020

rwalker-apple commented Dec 7, 2020

github-actions bot commented Dec 8, 2020

github-actions bot commented Dec 8, 2020

erjiaqing commented Dec 2, 2020 •

edited

Loading