Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Fix data loss or crash in TCPEndPoint with LwIP #4023

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Nov 30, 2020

A duplicate of #4022 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

kpschoedel and others added 2 commits November 30, 2020 11:04
#### Problem

Under the configuration CHIP_SYSTEM_CONFIG_USE_LWIP, in some cases where
the data size exceeds the TCP window size, TCPEndPoint can either die or
lose data when accounting of un-acked data falls out of sync.

#### Summary of Changes

Imported fix from Weave:

* This change removes separate accounting of the unsent
  data position and replaces it with simple counting of
  sent-but-not-acked data and a skip-loop at the start
  of DriveSending().

Fixes #4013 - Data loss or crash in TCPEndPoint with LwIP
@restyled-io restyled-io bot added the restyled label Nov 30, 2020
@boring-cyborg boring-cyborg bot added the inet label Nov 30, 2020
@restyled-io restyled-io bot closed this Nov 30, 2020
@restyled-io restyled-io bot deleted the restyled/pull-4022 branch November 30, 2020 16:23
@github-actions
Copy link

Size increase report for "esp32-example-build" from 7c17319

File Section File VM
chip-all-clusters-app.elf .flash.text 188 188
chip-all-clusters-app.elf .flash.rodata 96 96
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,3728
.debug_line,0,846
.debug_loc,0,378
.flash.text,188,188
.debug_str,0,176
.flash.rodata,96,96
.strtab,0,94
.debug_frame,0,48
.symtab,0,32
.debug_ranges,0,24
.debug_abbrev,0,18
.debug_aranges,0,16
.shstrtab,0,2
.xt.prop._ZN4chip8Encoding12LittleEndian7Write32ERPhj,0,-2
[Unmapped],0,-96


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants