-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow for ZAP templates generation #3929
Add Workflow for ZAP templates generation #3929
Conversation
@mspang @BroderickCarlin @andy31415 could we speed up the merge of this PR ? Sooner the CI is in master, the less issues will have with templates updates. |
Sorry for the delay. I am trying to figure out the long term plan for this - I expect at some point we will do generation as part of the build rather than separately. Is this PR intended as a test to validate that we can always 'zap gen' and will go away once we automatically generate? Also, any chance you could rebase to fix the cirque failure? |
8bec229
to
f69042d
Compare
Yup. This CI is mainly to prevent people from 2 things :
In the future this will be a pre-build step for every build CI job. However this cannot be for now for two simple reasons.
Since the templates are not complete and there's still some issues that need to be address with the templates already present in the repo, it doesn't make sense for now to work on adding the |
@andy31415 @mspang Can we merge this now ? |
861e949
to
039cafb
Compare
Problem
Since the ZAP templates are now within the CHIP repo, we needed a way to make sure that no could can break them.
Summary of Changes
Added a GitHub workflow to generate all the files needed for the
all_clusters_app
since it's the most complex configuration that we have. This workflow is an adaptation of the one found in the ZAP repo. Unfortunately node wasn't able to run on the chip-build container. Probably because of permission issues ( Issue #3928)Fixes #3885