Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all-clusters-app.zap file to all-clusters-app #3901

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

This PR contains the .zap configuration that maps the current configuration of the gen/ folder fore the all-clusters-app demo.

This is similar to #3610 and #3882

For example, one may generate the content of gen/ folder running:

./scripts/tools/zap_generate.sh examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

There is still a difference between this ZAP configuration and the current AppBuilder configuration though.
The current AppBuilder configuration uses 2 endpoints, while this configuration file uses 1. The rationale behind that is because ZAP does not (yet) generate endpoint_config.h which contains the code to deal with multiple endpoints.

I though it would make sense to wait for ZAP to be able to generate endpoint_config.h before adding this endpoint to the configuration file. But if reviewers think otherwise I can add it now.

At some point, we will get rid of the code of the gen/ folder. And the code should be generated from this file.

Summary of Changes

  • Add all-clusters-app.zap into examples/all-clusters-app/all-clusters-common

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping this for now. The real test will be when we generate gen from this an there are no changes, or we review the changes and they're ok....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants