[Darwin] Cleanup unused imports and forward declare where possible #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
approved these changes
Nov 18, 2020
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
bzbarsky-apple
approved these changes
Nov 18, 2020
rwalker-apple
approved these changes
Nov 18, 2020
andy31415
approved these changes
Nov 18, 2020
|
got any feedback @saurabhst @hawk248 @BroderickCarlin @jelderton ? |
|
I'll try that again :) @saurabhst @hawk248 @BroderickCarlin @jelderton ? |
sagar-apple
force-pushed
the
minor_fixes
branch
from
efb1975 to
ae8003c
Compare
saurabhst
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some unused imports and quoted includes cause build warnings when using the CHIPFramework.
Summary of Changes
Eliminated the build warnings by removing unused includes and replacing quoted headers with forward declarations or angle brackets where possible.