Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZAP submodule #3884

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

Update ZAP submodule. We need it for relative path in .zap files for #3882, #3610 and likely for the all-clusters-app

@jepenven-silabs
Copy link
Contributor

@vivien-apple while updating zap submodule is a good idea, it would make much more sense to track directly the master branch since ZAP is still under heavy development. This could be done by editing the zap_configure and zap_generate script so they checkout master and do a git pull at each run. Once ZAP is stable with a release version we could simply remove those lines and update the submodule when necessary.

@mspang
Copy link
Contributor

mspang commented Nov 17, 2020

@vivien-apple while updating zap submodule is a good idea, it would make much more sense to track directly the master branch since ZAP is still under heavy development. This could be done by editing the zap_configure and zap_generate script so they checkout master and do a git pull at each run. Once ZAP is stable with a release version we could simply remove those lines and update the submodule when necessary.

No.

We can track master, but we should do it by building automation to update the submodule.

@mspang mspang merged commit 34771f6 into project-chip:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants