Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IAS Zone Client Plugin callbacks into src/app/ias-zone-client #3772

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

#3464 does not have any informations about plugins and will not generate definitions or stubs for the IAS Zone Client methods.

Summary of Changes

  • Move IAS Zone Client plugin callbacks into src/app/clusters/ias-zone-client
  • Remove the related definitions/stubs from gen/clusters-callback-stubs.c

@vivien-apple vivien-apple force-pushed the Cluster_Plugin_IASZoneClient branch from bded0fa to 3a4571e Compare November 11, 2020 16:04
@github-actions
Copy link

Size increase report for "esp32-example-build" from eda6980

File Section File VM
chip-all-clusters-app.elf .flash.text -52 -52
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.shstrtab,0,3
.xt.prop._ZN4chip8Encoding12LittleEndian7Write32ERPhj,0,1
.debug_loc,0,-14
.debug_aranges,0,-16
.debug_ranges,0,-16
.debug_abbrev,0,-20
.symtab,0,-32
.flash.text,-52,-52
.debug_frame,0,-72
.debug_line,0,-107
.strtab,0,-131
.debug_info,0,-306
.debug_str,0,-346


@BroderickCarlin BroderickCarlin merged commit 3d7f598 into project-chip:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants