WIP: Build optimizations #37401
Draft
WIP: Build optimizations #37401
+151
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
adigie
force-pushed
the
toup-build-opt
branch
from
a4df653 to
445eb31
Compare
|
PR #37401: Size comparison from 577b3f2 to 445eb31 Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
Signed-off-by: Adrian Gielniewski <[email protected]>
adigie
force-pushed
the
toup-build-opt
branch
from
445eb31 to
e9170fb
Compare
adigie
force-pushed
the
toup-build-opt
branch
4 times, most recently
from
0101630 to
66fc382
Compare
github-actions
bot
added
examples
platform
linux
controller
telink
silabs
nxp
* Move OnboardingCodesUtils to separate target. * Remove shell dependency on server Signed-off-by: Adrian Gielniewski <[email protected]>
adigie
force-pushed
the
toup-build-opt
branch
from
66fc382 to
d5184df
Compare
andy31415
reviewed
Feb 5, 2025
| import("//build_overrides/chip.gni") | ||
| import("${chip_root}/src/app/common_flags.gni") | ||
|
|
||
| source_set("onboarding-codes-utils") { |
There was a problem hiding this comment.
you could make a sourceset without a separate folder too (less changes in include paths, so smaller delta).
Not strongly opposed either way. Somewhat concerned of a new folder with utils in the name since those tend to start accepting anything inside. Maybe just onboarding-codes would be sufficient (and we could rename the Util in the h/cpp as well, but that results in a larger delta.
andy31415
reviewed
Feb 5, 2025
| chip_device_platform == "openiotsdk" || | ||
| chip_device_platform == "nrfconnect" || | ||
| chip_device_platform == "esp32"))) { | ||
| if (chip_build_tests && !(chip_device_platform == "mbed" || |
There was a problem hiding this comment.
This change should probably be independent.
it does look more correct (i.e. test bits should depend on tests), however it also looks reasonably stand alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize nrfconnect build times.
Testing
Tested using automated tests.