Add a Matter.framework API for invoking multiple commands. #37398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
The API allows grouping the commands, so that later groups don't get invoked if anything in an earlier group fails. The changes to _invokeCommandWithEndpointID in MTRDevice_XPC.mm are fixing a pre-existing bug where it was not dispatching its completions to the right queue.
bzbarsky-apple
force-pushed
the
command-batching
branch
from
a0c93ca to
d66c54c
Compare
|
PR #37398: Size comparison from ecdf4eb to d66c54c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37398: Size comparison from ecdf4eb to 55d864c Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #37398: Size comparison from ecdf4eb to dd640a2 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API allows grouping the commands, so that later groups don't get invoked if anything in an earlier group fails.
The changes to _invokeCommandWithEndpointID in MTRDevice_XPC.mm are fixing a pre-existing bug where it was not dispatching its completions to the right queue.
Testing
Unit tests added in PR.