Fix availability annotations for XPC protocols in Matter.framework. #37211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were backwards-incompatible changes to MTRXPCServerProtocol_MTRDeviceController and MTRXPCServerProtocol, so mark those as not available before those changes, to avoid problems with people trying to use them before the change happened. controllerConfigurationUpdated and updateControllerConfiguration were added later than the protocol they are part of, and need to be annotated accordingly.
|
Review changes with |
|
PR #37211: Size comparison from d21aaa5 to a5227f0 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast-tracking platform-specific fix with platform owner review. |
arkq
approved these changes
Jan 27, 2025
woody-apple
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were backwards-incompatible changes to
MTRXPCServerProtocol_MTRDeviceController and MTRXPCServerProtocol, so mark those as not available before those changes, to avoid problems with people trying to use them before the change happened.
controllerConfigurationUpdated and updateControllerConfiguration were added later than the protocol they are part of, and need to be annotated accordingly.
Testing
Code inspection.