Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling BLE advertising start/stop command in shell application #3714

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

tima-q
Copy link
Contributor

@tima-q tima-q commented Nov 6, 2020

Problem

BLE commands (btp) in shell application are currently stubs.
Not all commands can be executed on a CHIP device side either.
The advertising start/stop can be enabled for a CHIP BLE peripheral.

Summary of Changes

Advertising command enabled using the ConnectivityMgr()
Scanning and setting up a connection has no API within ConnectivityMgr()

@github-actions
Copy link

github-actions bot commented Nov 6, 2020

Size increase report for "nrfconnect-example-build" from 69dcdb5

File Section File VM
chip-shell.elf text 80 80
chip-shell.elf rodata 64 68
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,11908
.debug_line,0,453
.debug_abbrev,0,355
.strtab,0,255
.symtab,0,96
text,80,80
rodata,68,64
.debug_loc,0,64
.debug_ranges,0,48
.debug_frame,0,4
.shstrtab,0,1


@bzbarsky-apple bzbarsky-apple merged commit 39cbaf7 into project-chip:master Nov 7, 2020
@tima-q tima-q deleted the shell/btp_adv_command branch November 8, 2020 19:24
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants