Feature/thermostat events xml ### Testing #36909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #36909: Size comparison from f05b65e to bde3911 Full report (5 builds for cc32xx, stm32, tizen)
|
|
PR #36909: Size comparison from f05b65e to 880c50d Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
There may be more changes as the last bit of the spec PR gets finalized.
|
PR #36909: Size comparison from f05b65e to 7fa387a Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Dec 19, 2024
| @@ -309,6 +309,9 @@ limitations under the License. | |||
| <feature bit="8" code="PRES" name="Presets" summary="Thermostat supports setpoint presets"> | |||
| <optionalConform/> | |||
| </feature> | |||
| <feature bit="9" code="TEVT" name="Events" summary="Thermostat supports events"> | |||
| <optionalConform/> | |||
There was a problem hiding this comment.
Shouldn't this be flagged provisional in the XML somehow for now?
There was a problem hiding this comment.
is there a way to do so? I ran alchemy this round instead of handcoding and it didn't mark it with the apiMaturity attribute like the other fields.
There was a problem hiding this comment.
It's possible that nothing supports apiMaturity on bitfields yet... if so, please reach out to @andy31415 and @hasty about fixing that.
There was a problem hiding this comment.
ZAP doesn't support apiMaturity outside of clusters, attributes, and structs. Of those, clusters and attributes currently have a method of specifying that they're provisional, in the sense that they have a conformance column; perhaps we should discuss in the DM TT call about how best to do this?
src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml
Outdated
Show resolved
Hide resolved
|
Once https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10444 is approved and merged I'll make it match the final spec that's chosen. |
|
PR #36909: Size comparison from 0dd3414 to a42ad1b Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36909: Size comparison from 40979b4 to 7d32a69 Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
ran zap_regen_all script
|
PR #36909: Size comparison from 40979b4 to fd859ae Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #36909: Size comparison from 5398152 to b497f92 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
drempelg
changed the title
drempelg
changed the title
drempelg
changed the title
|
PR #36909: Size comparison from ba98125 to 548f3c0 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36909: Size comparison from c0ee0a0 to ff4ec70 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML for https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10444