Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether data model provider is set in report callbacks #36881

Closed
wants to merge 1 commit into from
Closed

Check whether data model provider is set in report callbacks #36881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/app/reporting/reporting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,23 @@ void MatterReportingAttributeChangeCallback(EndpointId endpoint, ClusterId clust
// Attribute writes have asserted this already, but this assert should catch
// applications notifying about changes from their end.
assertChipStackLockedByCurrentThread();

InteractionModelEngine::GetInstance()->GetDataModelProvider()->Temporary_ReportAttributeChanged(
AttributePathParams(endpoint, clusterId, attributeId));
auto * engine = InteractionModelEngine::GetInstance();
VerifyOrReturn(engine);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is anyone calling this before data model has been initialized? That indicates a serious bug, and papering over it like this will just lead to wrong behavior as far as I can tell....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my test, InitChipStack() is called before Server instance is initialized. And before server instance is initialized, the connectivityMgr(this is initialized with the chip stack) might receive a Wi-Fi connect event, which will lead to that the Wi-Fi driver tries to call MatterReportingAttributeChangeCallback() to report the network status change. If the server instance doesn't set the data model provider for IM engine at that, there will be crash.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so this is a case where the attribute value is not owned by the data model at all, so it's ok if it's changing before the data model is set up?

Copy link
Contributor Author

@wqx6 wqx6 Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network status is read from the network driver so that it might be changed before data model is set up. I raised another PR #36939 which does the check before at where the network status is reported.

auto * dataModelProvider = engine->GetDataModelProvider();
VerifyOrReturn(dataModelProvider);
dataModelProvider->Temporary_ReportAttributeChanged(AttributePathParams(endpoint, clusterId, attributeId));
}

void MatterReportingAttributeChangeCallback(const ConcreteAttributePath & aPath)
{
// Attribute writes have asserted this already, but this assert should catch
// applications notifying about changes from their end.
assertChipStackLockedByCurrentThread();

InteractionModelEngine::GetInstance()->GetDataModelProvider()->Temporary_ReportAttributeChanged(
auto * engine = InteractionModelEngine::GetInstance();
VerifyOrReturn(engine);
auto * dataModelProvider = engine->GetDataModelProvider();
VerifyOrReturn(dataModelProvider);
dataModelProvider->Temporary_ReportAttributeChanged(
AttributePathParams(aPath.mEndpointId, aPath.mClusterId, aPath.mAttributeId));
}

Expand All @@ -49,6 +54,9 @@ void MatterReportingAttributeChangeCallback(EndpointId endpoint)
// Attribute writes have asserted this already, but this assert should catch
// applications notifying about changes from their end.
assertChipStackLockedByCurrentThread();

InteractionModelEngine::GetInstance()->GetDataModelProvider()->Temporary_ReportAttributeChanged(AttributePathParams(endpoint));
auto * engine = InteractionModelEngine::GetInstance();
VerifyOrReturn(engine);
auto * dataModelProvider = engine->GetDataModelProvider();
VerifyOrReturn(dataModelProvider);
dataModelProvider->Temporary_ReportAttributeChanged(AttributePathParams(endpoint));
}
Loading