Enforce a maximum entry limit during append operations #36843
Merged
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
force-pushed
the
pr/cluster/user_label
branch
from
f227584 to
dec1788
Compare
saurabhst
approved these changes
Dec 13, 2024
|
PR #36843: Size comparison from b49b845 to dec1788 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 14, 2024
There was a problem hiding this comment.
@yufengwangca please add a Testing section to your summary explaining how this was tested.
Since no test case was changed, I assume this was manual. We are trying to make manual annoying to type so that it is not done as a convenience, so please provide detailed test steps and explanation why automated testing was not possible (or better, if you can get some automated test that checks we get errors on large writes even better, unit test on DeviceInfoProvider if possible).
|
PR #36843: Size comparison from b49b845 to 78aa6c8 Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/cluster/user_label
branch
from
78aa6c8 to
99c5202
Compare
|
PR #36843: Size comparison from 43f66f0 to 99c5202 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlimited User Label Appends in Userlabel Cluster causes Resource Exhaustion and Potential DoS
Fix: #36760