Inject event management into report engine #36831
Open
+108
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36831: Size comparison from c55e3ab to f44a7a4 Full report (15 builds for bl602, bl702, bl702l, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36831: Size comparison from c55e3ab to d14ef63 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36831: Size comparison from c55e3ab to 1851566 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 13, 2024
andy31415
reviewed
Dec 13, 2024
andy31415
reviewed
Dec 13, 2024
There was a problem hiding this comment.
@yyzhong-g at a recent SWTT standup we decided to try once again for stricter "require tests".
Could you please add a "testing" section to describe how this were tested and since I see no unit tests updated or added as part of this PR to explain why this is ok. If manual testing, explain why this cannot be covered by automated tests (there should be a hight bar for saying "manually tested" because otherwise it is a simple escape hatch of saying "tested manually" on every PR).
Added a testing section in the description. Existing unit tests have coverages. |
|
PR #36831: Size comparison from c55e3ab to 8809618 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to decouple EventManagement with IMEngine singleton.
Inject EventManagement into ReportingEngine so it doesn't look for the global instance.
Creates EventScheduler interface (which is implemented by reporting engine) and inject into EventManagement to schedule events.
Created the EventScheduler to avoid both classes depends on each others. Also both classes are injected during Init call and takes the global one if not provided.
This is beneficial and allow us to have in-process testing (e.g. one client and one server running in parallel as different IM engines).
testing: Code changes are tested by existed unit tests, the tests verify that event are generated.