Adding string builder adapters for Milliseconds64 and Microseconds64 #36794

feasel0 · 2024-12-11T03:04:50Z

Adding string builder adapters for chip::System::Clock::Milliseconds64 and Microseconds64.

Instead of displaying like this:

src/platform/tests/TestPlatformTime.cpp:114: Failure
    Expected: Tdelta > (Tdelay - margin)
      Actual: <8-byte object at 0x3ffc1938> > <8-byte object at 0x3ffc1930>

A failure will now display like this:

src/platform/tests/TestPlatformTime.cpp:114: Failure
    Expected: Tdelta > (Tdelay - margin)
      Actual: 5ms > 8ms

… and Milliseconds64

semanticdiff-com · 2024-12-11T03:04:52Z

Review changes with

Changed Files

File	Status
scripts/tools/check_includes_config.py	0% smaller
src/lib/core/StringBuilderAdapters.cpp	Unsupported file format
src/lib/core/StringBuilderAdapters.h	Unsupported file format

github-actions · 2024-12-11T03:47:39Z

PR #36794: Size comparison from 29c6fd8 to 47e905b

Full report (8 builds for cc32xx, nrfconnect, stm32, tizen)

platform	target	config	section	`29c6fd8`	`47e905b`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	631050	631050
			RAM	205824	205824
	lock	CC3235SF_LAUNCHXL	FLASH	669646	669646
			RAM	205968	205968
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917616	917616
			RAM	143292	143292
		nrf7002dk_nrf5340_cpuapp	FLASH	890104	890104
			RAM	141487	141487
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	851760	851760
			RAM	142200	142200
stm32	light	STM32WB5MM-DK	FLASH	484720	484720
			RAM	144880	144880
tizen	all-clusters-app	arm	unknown	4988	4988
			FLASH	1732528	1732528
			RAM	90744	90744
	chip-tool-ubsan	arm	unknown	10804	10804
			FLASH	17969478	17969478
			RAM	7840748	7840748

github-actions · 2024-12-11T04:25:03Z

PR #36794: Size comparison from 29c6fd8 to 0359b82

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`29c6fd8`	`0359b82`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1353340	1353340	0	0.0
			RAM	104112	104112	0	0.0
bl702	lighting-app	bl702+eth	FLASH	651826	651826	0	0.0
			RAM	25353	25353	0	0.0
		bl702+wifi	FLASH	829154	829154	0	0.0
			RAM	14093	14093	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1057626	1057626	0	0.0
			RAM	23933	23933	0	0.0
bl702l	lighting-app	bl702l+mfd+littlefs	FLASH	979000	979000	0	0.0
			RAM	16596	16596	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	839760	839760	0	0.0
			RAM	123664	123664	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	825308	825308	0	0.0
			RAM	125552	125552	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	772096	772096	0	0.0
			RAM	114020	114020	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	756284	756284	0	0.0
			RAM	114228	114228	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	631050	631050	0	0.0
			RAM	205824	205824	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	669646	669646	0	0.0
			RAM	205968	205968	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	681505	681505	0	0.0
			RAM	78724	78724	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	701349	701349	0	0.0
			RAM	81364	81364	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	701349	701349	0	0.0
			RAM	81364	81364	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	658293	658293	0	0.0
			RAM	73792	73792	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	618065	618065	0	0.0
			RAM	71708	71708	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	637693	637693	0	0.0
			RAM	74252	74252	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	637693	637693	0	0.0
			RAM	74252	74252	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	637465	637465	0	0.0
			RAM	74724	74724	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	657173	657173	0	0.0
			RAM	77268	77268	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	657173	657173	0	0.0
			RAM	77268	77268	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	613925	613925	0	0.0
			RAM	68812	68812	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	633777	633777	0	0.0
			RAM	71444	71444	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	633777	633777	0	0.0
			RAM	71444	71444	0	0.0
efr32	lock-app	BRD4187C	FLASH	932340	932340	0	0.0
			RAM	160192	160192	0	0.0
		BRD4338a	FLASH	746144	746136	-8	-0.0
			RAM	233320	233320	0	0.0
	window-app	BRD4187C	FLASH	`1024784`	`1024784`	0	0.0
			RAM	128296	128296	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	95360	95360	0	0.0
			FLASH	1543480	1543480	0	0.0
			IRAM	82542	82542	0	0.0
		m5stack	DRAM	116312	116312	0	0.0
			FLASH	1550134	1550134	0	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4720	4720	0	0.0
			FLASH	2715063	2715063	0	0.0
			RAM	129800	129800	0	0.0
	all-clusters-app	debug	unknown	5560	5560	0	0.0
			FLASH	6007064	6007064	0	0.0
			RAM	523544	523544	0	0.0
	all-clusters-minimal-app	debug	unknown	5456	5456	0	0.0
			FLASH	5344804	5344804	0	0.0
			RAM	242600	242600	0	0.0
	bridge-app	debug	unknown	5440	5440	0	0.0
			FLASH	4684372	4684372	0	0.0
			RAM	218416	218416	0	0.0
	chip-tool	debug	unknown	5992	5992	0	0.0
			FLASH	12847612	12847612	0	0.0
			RAM	582474	582474	0	0.0
	chip-tool-ipv6only	arm64	unknown	21344	21344	0	0.0
			FLASH	10982320	10982320	0	0.0
			RAM	633384	633384	0	0.0
	fabric-admin	debug	unknown	5816	5816	0	0.0
			FLASH	11254413	11254413	0	0.0
			RAM	582850	582850	0	0.0
	fabric-bridge-app	debug	unknown	4696	4696	0	0.0
			FLASH	4509948	4509948	0	0.0
			RAM	205600	205600	0	0.0
	fabric-sync	debug	unknown	4936	4936	0	0.0
			FLASH	5608853	5608853	0	0.0
			RAM	472584	472584	0	0.0
	lighting-app	debug+rpc+ui	unknown	6104	6104	0	0.0
			FLASH	5621073	5621073	0	0.0
			RAM	228792	228792	0	0.0
	lock-app	debug	unknown	5376	5376	0	0.0
			FLASH	4733612	4733612	0	0.0
			RAM	204776	204776	0	0.0
	ota-provider-app	debug	unknown	4752	4752	0	0.0
			FLASH	4359350	4359350	0	0.0
			RAM	198448	198448	0	0.0
	ota-requestor-app	debug	unknown	4688	4688	0	0.0
			FLASH	4498342	4498342	0	0.0
			RAM	203032	203032	0	0.0
	shell	debug	unknown	4248	4248	0	0.0
			FLASH	3030077	3030077	0	0.0
			RAM	160424	160424	0	0.0
	thermostat-no-ble	arm64	unknown	9536	9536	0	0.0
			FLASH	4103472	4103472	0	0.0
			RAM	243040	243040	0	0.0
	tv-app	debug	unknown	5704	5704	0	0.0
			FLASH	5958773	5958773	0	0.0
			RAM	596016	596016	0	0.0
	tv-casting-app	debug	unknown	5288	5288	0	0.0
			FLASH	11054365	11054365	0	0.0
			RAM	692152	692152	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917616	917616	0	0.0
			RAM	143292	143292	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	890104	890104	0	0.0
			RAM	141487	141487	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	851760	851760	0	0.0
			RAM	142200	142200	0	0.0
nxp	contact	k32w0+release	FLASH	585440	585440	0	0.0
			RAM	71080	71080	0	0.0
		mcxw71+release	FLASH	600048	600048	0	0.0
			RAM	63176	63176	0	0.0
	light	k32w0+release	FLASH	612396	612396	0	0.0
			RAM	70472	70472	0	0.0
		k32w1+release	FLASH	686576	686576	0	0.0
			RAM	48808	48808	0	0.0
	lock	mcxw71+release	FLASH	762928	762928	0	0.0
			RAM	70844	70844	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646364	1646364	0	0.0
			RAM	212104	212104	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	`1554108`	`1554108`	0	0.0
			RAM	208904	208904	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1469436	1469436	0	0.0
			RAM	200880	200880	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1467164	1467164	0	0.0
			RAM	225240	225240	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	664008	664008	0	0.0
			RAM	105424	105424	0	0.0
	lock-app	qpg6105+debug	FLASH	621796	621796	0	0.0
			RAM	99868	99868	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	484720	484720	0	0.0
			RAM	144880	144880	0	0.0
telink	bridge-app	tlsr9258a	FLASH	682920	682920	0	0.0
			RAM	91208	91208	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	623350	623350	0	0.0
			RAM	31440	31440	0	0.0
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	772180	772180	0	0.0
			RAM	49300	49300	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	710774	710774	0	0.0
			RAM	73504	73504	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	627794	627794	0	0.0
			RAM	142140	142140	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813808	813808	0	0.0
			RAM	99684	99684	0	0.0
tizen	all-clusters-app	arm	unknown	4988	4988	0	0.0
			FLASH	1732528	1732528	0	0.0
			RAM	90744	90744	0	0.0
	chip-tool-ubsan	arm	unknown	10804	10804	0	0.0
			FLASH	17969478	17969478	0	0.0
			RAM	7840748	7840748	0	0.0

…roject-chip#36794) * Added string builder adaptesr for chip::System::Clock::Microseconds64 and Milliseconds64 * Restyled by clang-format * Cast the time to llu because some platforms use lu. * Added exception for chrono to check_includes_config.py --------- Co-authored-by: Restyled.io <[email protected]>

Added string builder adaptesr for chip::System::Clock::Microseconds64…

f0b7c56

… and Milliseconds64

pullapprove bot added the review - pending label Dec 11, 2024

github-actions bot added lib core labels Dec 11, 2024

restyled-commits and others added 2 commits December 10, 2024 22:07

Restyled by clang-format

51a702d

Cast the time to llu because some platforms use lu.

47e905b

Added exception for chrono to check_includes_config.py

0359b82

github-actions bot added the scripts label Dec 11, 2024

feasel0 changed the title ~~Adding pw string builder adapters for Microseconds64 and Milliseconds64~~ Adding string builder adapters for Microseconds64 and Milliseconds64 Dec 11, 2024

feasel0 changed the title ~~Adding string builder adapters for Microseconds64 and Milliseconds64~~ Adding string builder adapters for Milliseconds64 and Microseconds64 Dec 11, 2024

arkq approved these changes Dec 11, 2024

View reviewed changes

andy31415 approved these changes Dec 11, 2024

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Dec 11, 2024

mergify bot merged commit c799e5c into project-chip:master Dec 11, 2024
67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding string builder adapters for Milliseconds64 and Microseconds64 #36794

Adding string builder adapters for Milliseconds64 and Microseconds64 #36794

feasel0 commented Dec 11, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

Adding string builder adapters for Milliseconds64 and Microseconds64 #36794

Adding string builder adapters for Milliseconds64 and Microseconds64 #36794

Conversation

feasel0 commented Dec 11, 2024 • edited Loading

semanticdiff-com bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

feasel0 commented Dec 11, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading