Make XOccupiedToUnoccupiedDelay attributes in OccupancySensing cluster managed by AAI #36777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #36777: Size comparison from 5d42d92 to 35d065b Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36777: Size comparison from 5d42d92 to 736a7e8 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 13, 2024
|
PR #36777: Size comparison from 9e203e2 to 62ef0b6 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 13, 2024
There was a problem hiding this comment.
@wqx6 please add a Testing section to describe how this change was tested.
Since I see no unit test changes, this may be "manual" in which case please describe testing in more detail (what commands were run, what output existed before and what is the new behavior) as well as a justification why this change is impossible to test automatically.
Done |
andy31415
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are managing the
*OccupiedToUnoccupiedDelayattributes in the Write function of AAI for OccupancySensing cluster but these attributes are not added in theattributeAccessInterfaceAttributesin thezcl.json. So make all these attributes managed by AAI.Test
Test writing and reading HoldTime and PIROccupiedToUnoccupiedDelay attributes before and after this PR, the results are the same.