Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use default ctor for ChipDeviceEvent #36768

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Don't use default ctor for ChipDeviceEvent #36768

merged 2 commits into from
Dec 10, 2024

Conversation

soares-sergio
Copy link
Contributor

This PR updates the instantiation of ChipDeviceEvent to avoid using the default constructor. This fixes some build errors such as:

src/protocols/secure_channel/PairingSession.cpp:84:38: error: call to implicitly-deleted default constructor of 'DeviceLayer::ChipDeviceEvent'
   84 |         DeviceLayer::ChipDeviceEvent event;
      |                                      ^
src/include/platform/CHIPDeviceEvent.h:499:11: note: default constructor of 'ChipDeviceEvent' is implicitly deleted because variant field 'CHIPoBLEConnectionError' has a non-trivial default constructor
  499 |         } CHIPoBLEConnectionError;
      |           ^
1 error generated.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

PR #36768: Size comparison from 73cc4f1 to f9e5555

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 73cc4f1 f9e5555 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353308 1353340 32 0.0
RAM 104112 104112 0 0.0
bl702 lighting-app bl702+eth FLASH 651816 651826 10 0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829144 829154 10 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057594 1057626 32 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978968 979000 32 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839736 839760 24 0.0
RAM 123664 123664 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825276 825308 32 0.0
RAM 125552 125552 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772064 772096 32 0.0
RAM 114020 114020 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756260 756284 24 0.0
RAM 114228 114228 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 631026 631050 24 0.0
RAM 205824 205824 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669622 669646 24 0.0
RAM 205968 205968 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681473 681505 32 0.0
RAM 78724 78724 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701325 701349 24 0.0
RAM 81364 81364 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701325 701349 24 0.0
RAM 81364 81364 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658261 658293 32 0.0
RAM 73792 73792 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618033 618065 32 0.0
RAM 71708 71708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637661 637693 32 0.0
RAM 74252 74252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637661 637693 32 0.0
RAM 74252 74252 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637433 637465 32 0.0
RAM 74724 74724 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657149 657173 24 0.0
RAM 77268 77268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657149 657173 24 0.0
RAM 77268 77268 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613901 613925 24 0.0
RAM 68812 68812 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633753 633777 24 0.0
RAM 71444 71444 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633753 633777 24 0.0
RAM 71444 71444 0 0.0
efr32 lock-app BRD4187C FLASH 932308 932340 32 0.0
RAM 160192 160192 0 0.0
BRD4338a FLASH 746112 746136 24 0.0
RAM 233320 233320 0 0.0
window-app BRD4187C FLASH 1024752 1024784 32 0.0
RAM 128296 128296 0 0.0
esp32 all-clusters-app c3devkit DRAM 95360 95360 0 0.0
FLASH 1543466 1543480 14 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116312 116312 0 0.0
FLASH 1550118 1550134 16 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2715045 2715063 18 0.0
RAM 129800 129800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6007046 6007064 18 0.0
RAM 523544 523544 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5344786 5344804 18 0.0
RAM 242600 242600 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4684354 4684372 18 0.0
RAM 218416 218416 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12847594 12847612 18 0.0
RAM 582474 582474 0 0.0
chip-tool-ipv6only arm64 unknown 21344 21344 0 0.0
FLASH 10982304 10982320 16 0.0
RAM 633384 633384 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11254395 11254413 18 0.0
RAM 582850 582850 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4509930 4509948 18 0.0
RAM 205600 205600 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5607797 5607813 16 0.0
RAM 472584 472584 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5621057 5621073 16 0.0
RAM 228792 228792 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4733594 4733612 18 0.0
RAM 204776 204776 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4359332 4359350 18 0.0
RAM 198448 198448 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4498324 4498342 18 0.0
RAM 203032 203032 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3030061 3030077 16 0.0
RAM 160424 160424 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4103456 4103472 16 0.0
RAM 243040 243040 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5958757 5958773 16 0.0
RAM 596016 596016 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11054349 11054365 16 0.0
RAM 692152 692152 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917588 917616 28 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890096 890104 8 0.0
RAM 141487 141487 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851732 851760 28 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 585408 585440 32 0.0
RAM 71080 71080 0 0.0
mcxw71+release FLASH 600016 600048 32 0.0
RAM 63176 63176 0 0.0
light k32w0+release FLASH 612364 612396 32 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 686552 686576 24 0.0
RAM 48808 48808 0 0.0
lock mcxw71+release FLASH 762896 762928 32 0.0
RAM 70844 70844 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646348 1646364 16 0.0
RAM 212104 212104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554092 1554108 16 0.0
RAM 208904 208904 0 0.0
light cy8ckit_062s2_43012 FLASH 1469404 1469436 32 0.0
RAM 200880 200880 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467148 1467164 16 0.0
RAM 225240 225240 0 0.0
qpg lighting-app qpg6105+debug FLASH 663976 664008 32 0.0
RAM 105424 105424 0 0.0
lock-app qpg6105+debug FLASH 621772 621796 24 0.0
RAM 99868 99868 0 0.0
stm32 light STM32WB5MM-DK FLASH 484696 484720 24 0.0
RAM 144880 144880 0 0.0
telink bridge-app tlsr9258a FLASH 682888 682920 32 0.0
RAM 91208 91208 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623318 623350 32 0.0
RAM 31440 31440 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772148 772180 32 0.0
RAM 49300 49300 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710742 710774 32 0.0
RAM 73504 73504 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627784 627794 10 0.0
RAM 142140 142140 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813776 813808 32 0.0
RAM 99684 99684 0 0.0
tizen all-clusters-app arm unknown 4988 4988 0 0.0
FLASH 1732480 1732528 48 0.0
RAM 90744 90744 0 0.0
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17969438 17969478 40 0.0
RAM 7840748 7840748 0 0.0

@mergify mergify bot merged commit 8606290 into project-chip:master Dec 10, 2024
67 checks passed
@soares-sergio soares-sergio deleted the fix_chip_device_event_error branch December 10, 2024 14:56
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@soares-sergio @restyled-commits @yyzhong-g
Don't use default ctor for ChipDeviceEvent (project-chip#36768)
45bb1fa 
* Don't use default ctor for ChipDeviceEvent

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@arkq arkq arkq approved these changes

Assignees
No one assigned
Labels
lib protocols review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soares-sergio @arkq @bzbarsky-apple @restyled-commits