-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
da_revocation: option to load test data from the test without using file #36759
Merged
mergify
merged 3 commits into
project-chip:master
from
shubhamdp:da_revocation_ut_simplify
Dec 13, 2024
Merged
da_revocation: option to load test data from the test without using file #36759
mergify
merged 3 commits into
project-chip:master
from
shubhamdp:da_revocation_ut_simplify
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #36759: Size comparison from 84fb78f to c9f43ff Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
PR #36759: Size comparison from 84fb78f to 58b25c3 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Dec 11, 2024
bzbarsky-apple
approved these changes
Dec 13, 2024
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
shubhamdp
force-pushed
the
da_revocation_ut_simplify
branch
from
December 13, 2024 05:15
d313c94
to
00e991e
Compare
PR #36759: Size comparison from 8ea6b8d to 00e991e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34588
Added APIs for loading and clearing json data and modified unit tests to use those APIs.