Remove Active flag when the readhandler is going to be destroyed #36653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36653: Size comparison from e98f2b2 to a600a94 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Nov 28, 2024
arkq
approved these changes
Nov 29, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ject-chip#36653) * remove Active flag when the readhandler is going to be destroyed * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the OnSubscriptionTerminated callback is called, the readhandler that is being destroyed is still marked as active even if the destructor has been called.
Due to this, if we want to check the state of the different subscription for the fabric, the readhandler that is being destroyed skews the results since it is marked as active. This renders the SubscriptionInfoProvider pointless since any check has risk of returning a false positive.
PR removes the ActiveSubscription flag before calling the OnSubscriptionTerminated to avoid having false positives when checking for active subscriptions on the fabric afterwards. This also prevents the OnSubscriptionTerminated to be called twice if for some reason the destructor is called twice we shouldn't happen.
Tests
CI