[ESP32] Added GetThreadMetrics Implementation to DiagnosticDataProvider #36609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36609: Size comparison from 04e6a68 to dda4740 Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
dda4740 to
ff7f0f7
Compare
|
PR #36609: Size comparison from 04e6a68 to ff7f0f7 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
ff7f0f7 to
b08ae45
Compare
|
PR #36609: Size comparison from 0ac52eb to b08ae45 Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
2 times, most recently
from
9ea6c7a to
4a100df
Compare
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
4a100df to
4d26618
Compare
|
PR #36609: Size comparison from 0ac52eb to 4d26618 Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
2 times, most recently
from
dc44474 to
c12c3c5
Compare
|
PR #36609: Size comparison from 0ac52eb to c12c3c5 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
reviewed
Nov 29, 2024
shubhamdp
reviewed
Nov 29, 2024
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
c12c3c5 to
4dd7d62
Compare
|
PR #36609: Size comparison from fb24b90 to 4dd7d62 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
approved these changes
Dec 2, 2024
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
4dd7d62 to
dd29534
Compare
|
PR #36609: Size comparison from e402b96 to dd29534 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 5, 2024
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
dd29534 to
4dd7d62
Compare
|
PR #36609: Size comparison from 5ba09fd to 4dd7d62 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36609: Size comparison from 5ba09fd to 40ce3da Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
40ce3da to
e7a60f8
Compare
|
PR #36609: Size comparison from 879433f to e7a60f8 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
e7a60f8 to
800b061
Compare
dhrishi
approved these changes
Dec 5, 2024
|
PR #36609: Size comparison from ee1577a to 800b061 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
force-pushed
the
esp32/threadmatrics
branch
from
800b061 to
1ab36b9
Compare
|
PR #36609: Size comparison from 22d490a to 1ab36b9 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…er (project-chip#36609) * esp32: implement thread metrics for software diagnostics cluster * esp32: resolve repeated return statement issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The DiagnosticDataProvider for the ESP32 platform lacks an implementation of the GetThreadMetrics() method.
Change Overview:
Implemented the GetThreadMetrics() and ReleaseThreadMetrics() methods in DiagnosticDataProviderImpl.cpp and DiagnosticDataProviderImpl.h.
Testing:
Successfully read thread metrics using the Software Diagnostic Cluster in the lighting-app on ESP32-C3.