Add some constraint checks to the colorcontrol cluster commands #36542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36542: Size comparison from 9eed8b4 to 24c361e Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Nov 18, 2024
mkardous-silabs
approved these changes
Nov 18, 2024
Co-authored-by: lpbeliveau-silabs <[email protected]>
|
PR #36542: Size comparison from 9eed8b4 to c4a7ed8 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…cks. Add contraint checks for ColorTemperatureMireds arguments
|
PR #36542: Size comparison from 9eed8b4 to 6f5bbf2 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Nov 22, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…ect-chip#36542) * add some constraint checks to the colorcontrol cluster commands * Update src/app/clusters/color-control-server/color-control-server.cpp Co-authored-by: lpbeliveau-silabs <[email protected]> * Addrese comments. Move ConstraintCheck Before Unsupported command checks. Add contraint checks for ColorTemperatureMireds arguments * Update src/app/clusters/color-control-server/color-control-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: lpbeliveau-silabs <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ect-chip#36542) * add some constraint checks to the colorcontrol cluster commands * Update src/app/clusters/color-control-server/color-control-server.cpp Co-authored-by: lpbeliveau-silabs <[email protected]> * Addrese comments. Move ConstraintCheck Before Unsupported command checks. Add contraint checks for ColorTemperatureMireds arguments * Update src/app/clusters/color-control-server/color-control-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: lpbeliveau-silabs <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34721
Add some constraint check to color control commands, mostly for the transitionTime argument.
TC_CC_ tests validates that there is no regression