Handle ACL and readability in reporting/Engine.cpp
#36488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36488: Size comparison from 45a75ba to 1df0e39 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
andy31415
commented
Nov 13, 2024
|
PR #36488: Size comparison from 45a75ba to 122a60c Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36488: Size comparison from 45a75ba to 7bab9a7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Nov 15, 2024
bzbarsky-apple
approved these changes
Nov 19, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
tcarmelveilleux
approved these changes
Nov 19, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
) * Move ACL validation in reporting engine for reads * Fix up logic for ACL & return codes * Take into consideration global attributes: their ACL is ok * Make testread pass (with hacks because the test is not sane) * Update comment and model setting. * Another comment update * Fix includes * Fix typo * Restyled by clang-format * Update comment * Update ACL test logic and revert testread to original setup * Restyle * Address review comments * Restyle * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Restyle * Fix extra bracket --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
) * Move ACL validation in reporting engine for reads * Fix up logic for ACL & return codes * Take into consideration global attributes: their ACL is ok * Make testread pass (with hacks because the test is not sane) * Update comment and model setting. * Another comment update * Fix includes * Fix typo * Restyled by clang-format * Update comment * Update ACL test logic and revert testread to original setup * Restyle * Address review comments * Restyle * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Restyle * Fix extra bracket --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #36484: move the ACL validation out of
DataModel::Provider::ReadAttributeand have this handled by the interaction model reporting engine based on the metadata passed in by the provider.