Migrate from deprecated OpenSSL SHA256_* APIs to EVP APIs #36386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Alami-Amine
force-pushed
the
AA/OpenSSLHashAPI
branch
3 times, most recently
from
112d4da to
1b79b1e
Compare
|
PR #36386: Size comparison from da2b767 to 1b79b1e Full report (17 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink)
|
Alami-Amine
force-pushed
the
AA/OpenSSLHashAPI
branch
from
1b79b1e to
e42374b
Compare
|
PR #36386: Size comparison from da2b767 to e42374b Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/OpenSSLHashAPI
branch
from
e42374b to
4ff3187
Compare
|
PR #36386: Size comparison from 6cf10d7 to 4ff3187 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 6, 2024
andy31415
reviewed
Nov 6, 2024
andy31415
reviewed
Nov 6, 2024
andy31415
reviewed
Nov 6, 2024
andy31415
approved these changes
Nov 6, 2024
|
PR #36386: Size comparison from 6cf10d7 to 03b5cf5 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/OpenSSLHashAPI
branch
from
03b5cf5 to
16d2c9a
Compare
|
PR #36386: Size comparison from 4edae20 to 16d2c9a Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Nov 7, 2024
jmartinez-silabs
approved these changes
Nov 7, 2024
Alami-Amine
added a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Nov 22, 2024
This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Alami-Amine
added a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Nov 22, 2024
This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Alami-Amine
added a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Nov 22, 2024
This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This is a follow_up to #36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…hip#36608) This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ip#36386) * Migrate from deprecated OpenSSL SHA256_* APIs to EVP APIs * Integrating comments
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…hip#36608) This is a follow_up to project-chip#36386 based on a post-merge comment, - an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends - Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from deprecated OpenSSL SHA256_* APIs to the higher-level EVP APIs:
SHA256_Init,SHA256_UpdateandSHA256_Final, details hereNOTE: The Digest Context
EVP_MD_CTXwith these new APIs is Opaque, and thusHashSHA256OpaqueContextwas used to store the pointer to SHA256 Context (EVP_MD_CTX) instead of the structure itself (as was originally intended forHashSHA256OpaqueContext).Testing