Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] First Refactor of the SiWx917 Wi-Fi Interface #36305

Merged
merged 12 commits into from
Oct 30, 2024
Merged

[Silabs] First Refactor of the SiWx917 Wi-Fi Interface #36305

merged 12 commits into from
Oct 30, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR refactors a big chunk of the SiWx917 Wi-Fi interface to reduce overall dupication and increase quality.
Since there was a signifcant amount of things to changes, this PR addresses the first chunck while leaving some workarounds to be addressed in follow ups since it was impossible to fix evertying in the first go.

Note to reviewers

Other than style comments, any functionnal comments will be addressed in the follow up refactor PR.
PR will be fast tracked due to the size of it and the limited changes to the Silabs platform

Tests

Manual tests to validate no regression were introduced

@mkardous-silabs mkardous-silabs requested a review from a team as a code owner October 30, 2024 18:43
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 30, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  build_overrides/efr32_sdk.gni Unsupported file format
  examples/air-quality-sensor-app/silabs/BUILD.gn Unsupported file format
  examples/build_overrides/efr32_sdk.gni Unsupported file format
  examples/chef/silabs/BUILD.gn Unsupported file format
  examples/dishwasher-app/silabs/BUILD.gn Unsupported file format
  examples/energy-management-app/silabs/BUILD.gn Unsupported file format
  examples/light-switch-app/silabs/BUILD.gn Unsupported file format
  examples/lighting-app/silabs/BUILD.gn Unsupported file format
  examples/lit-icd-app/silabs/BUILD.gn Unsupported file format
  examples/lock-app/silabs/BUILD.gn Unsupported file format
  examples/platform/silabs/FreeRTOSConfig.h Unsupported file format
  examples/platform/silabs/MatterConfig.cpp Unsupported file format
  examples/platform/silabs/MatterConfig.h Unsupported file format
  examples/platform/silabs/SiWx917/BUILD.gn Unsupported file format
  examples/platform/silabs/SiWx917/SiWx917/sl_wlan_config.h Unsupported file format
  examples/platform/silabs/SiWx917/SiWxWifiInterface.cpp Unsupported file format
  examples/platform/silabs/efr32/BUILD.gn Unsupported file format
  examples/platform/silabs/efr32/rs911x/rs9117.gni Unsupported file format
  examples/platform/silabs/efr32/rs911x/rs911x.gni Unsupported file format
  examples/platform/silabs/efr32/rs911x/rsi_if.cpp Unsupported file format
  examples/platform/silabs/efr32/rs911x/sl_wifi_if.cpp  0% smaller
  examples/platform/silabs/efr32/rs911x/sl_wlan_config.h Unsupported file format
  examples/platform/silabs/efr32/wf200/host_if.cpp Unsupported file format
  examples/platform/silabs/efr32/wf200/wf200.gni Unsupported file format
  examples/platform/silabs/provision/BUILD.gn Unsupported file format
  examples/platform/silabs/wfx_rsi.h Unsupported file format
  examples/platform/silabs/wifi/wfx_notify.cpp Unsupported file format
  examples/platform/silabs/wifi/wfx_rsi_host.cpp Unsupported file format
  examples/pump-app/silabs/BUILD.gn Unsupported file format
  examples/smoke-co-alarm-app/silabs/BUILD.gn Unsupported file format
  examples/thermostat/silabs/BUILD.gn Unsupported file format
  examples/window-app/silabs/BUILD.gn Unsupported file format
  src/lwip/BUILD.gn Unsupported file format
  src/platform/silabs/ConfigurationManagerImpl.cpp Unsupported file format
  src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp Unsupported file format
  src/platform/silabs/NetworkCommissioningWiFiDriver.cpp Unsupported file format
  src/platform/silabs/PlatformManagerImpl.cpp Unsupported file format
  src/platform/silabs/SiWx917/BUILD.gn Unsupported file format
  src/platform/silabs/SiWx917/wifi/ethernetif.cpp Unsupported file format
  src/platform/silabs/SiWx917/wifi/ethernetif.h Unsupported file format
  src/platform/silabs/SiWx917/wifi/lwip_netif.cpp Unsupported file format
  src/platform/silabs/SiWx917/wifi/wifi_config.h Unsupported file format
  src/platform/silabs/efr32/BUILD.gn Unsupported file format
  src/platform/silabs/efr32/args.gni Unsupported file format
  src/platform/silabs/efr32/wifi/ethernetif.cpp Unsupported file format
  src/platform/silabs/efr32/wifi/lwip_netif.cpp Unsupported file format
  src/platform/silabs/efr32/wifi/wifi_config.h Unsupported file format
  src/platform/silabs/provision/BUILD.gn Unsupported file format
  src/platform/silabs/wifi/dhcp_client.cpp Unsupported file format
  src/platform/silabs/wifi/wfx_host_events.h Unsupported file format
  src/platform/silabs/wifi_args.gni Unsupported file format
  src/system/BUILD.gn Unsupported file format
  src/test_driver/efr32/BUILD.gn Unsupported file format
  src/test_driver/efr32/args.gni Unsupported file format
  third_party/openthread/platforms/efr32/BUILD.gn Unsupported file format
  third_party/silabs/BUILD.gn Unsupported file format
  third_party/silabs/SiWx917_sdk.gni Unsupported file format
  third_party/silabs/lwip.gni Unsupported file format
  third_party/silabs/matter_support  0% smaller
  third_party/silabs/silabs_lwip/BUILD.gn Unsupported file format

@mkardous-silabs mkardous-silabs added submodules Pull requests that update Submodules code changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) labels Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

PR #36305: Size comparison from f985d72 to 052c5f9

Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
platform target config section f985d72 052c5f9 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349306 1349306 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647028 647028 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824592 824592 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053582 1053582 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974366 974366 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836124 836124 0 0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821768 821768 0 0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768476 768476 0 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752720 752720 0 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625798 625798 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 665774 665774 0 0.0
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678085 678085 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697937 697937 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697937 697937 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654873 654873 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614637 614637 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634149 634149 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653857 653857 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653857 653857 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609429 609429 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913336 913336 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884780 884780 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847396 847396 0 0.0
RAM 142265 142265 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641508 1641508 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549052 1549052 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1465636 1465636 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463300 1463300 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660304 660304 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618380 618380 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481392 481392 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680800 680800 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620426 620426 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708260 708260 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625062 625062 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811072 811072 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1712792 1712792 0 0.0
RAM 90140 90140 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1794227 1794227 0 0.0
RAM 7811564 7811564 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

PR #36305: Size comparison from f985d72 to d12e98c

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f985d72 d12e98c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349306 1349306 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647028 647028 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824592 824592 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053582 1053582 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974366 974366 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836124 836124 0 0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821768 821768 0 0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768476 768476 0 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752720 752720 0 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625798 625798 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 665774 665774 0 0.0
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678085 678085 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697937 697937 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697937 697937 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654873 654873 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614637 614637 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634273 634273 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634149 634149 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653857 653857 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653857 653857 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609429 609429 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 926068 926100 32 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 740568 741952 1384 0.2
RAM 232580 233032 452 0.2
window-app BRD4187C FLASH 1017272 1017304 32 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1537464 1537464 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548126 1548126 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2731595 2731595 0 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6021350 6021350 0 0.0
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5358592 5358592 0 0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4700450 4700450 0 0.0
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12901220 12901220 0 0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11029376 11029376 0 0.0
RAM 635400 635400 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11308753 11308753 0 0.0
RAM 584922 584922 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4527502 4527502 0 0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5239621 5239621 0 0.0
RAM 465432 465432 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5638961 5638961 0 0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4748870 4748870 0 0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4375630 4375630 0 0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4513870 4513870 0 0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3048605 3048605 0 0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4117192 4117192 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5971893 5971893 0 0.0
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11108589 11108589 0 0.0
RAM 694552 694552 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913336 913336 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884780 884780 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847396 847396 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582296 0 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596784 596784 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618852 618852 0 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682928 682928 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746560 746560 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641508 1641508 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549052 1549052 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1465636 1465636 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463300 1463300 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660304 660304 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618380 618380 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481392 481392 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680800 680800 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620426 620426 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708260 708260 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625062 625062 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811072 811072 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1712792 1712792 0 0.0
RAM 90140 90140 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1794227 1794227 0 0.0
RAM 7811564 7811564 0 0.0

@mkardous-silabs mkardous-silabs enabled auto-merge (squash) October 30, 2024 20:17
@mkardous-silabs mkardous-silabs merged commit 554c578 into project-chip:master Oct 30, 2024
68 checks passed
@mkardous-silabs mkardous-silabs deleted the feature/wifi_clean_up branch October 30, 2024 22:00
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@mkardous-silabs @yyzhong-g
[Silabs] First Refactor of the SiWx917 Wi-Fi Interface (project-chip#…
e6f698a 
…36305)

* Rename efr32_sdk_build_root to silabs_sdk_build_root

* Remove wifi_config.h and move standard to C++

* Refactor SiW917 Wi-Fi application implementation

* remove commented source file

* fix ICD build issues

* rename file

* continue clean up

* Set working wifi_sdk hash

* Finish clean up

* Update submodules

* update comment

* Adress review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees
No one assigned
Labels
changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) examples fast track gn lwip platform silabs submodules Pull requests that update Submodules code system test driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkardous-silabs @jmartinez-silabs