Add new API so it's possible to not leak a key #36299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
anush-apple
approved these changes
Oct 30, 2024
|
PR #36299: Size comparison from fe5ddda to e3735b2 Full report (3 builds for cc32xx, stm32)
|
|
PR #36299: Size comparison from fe5ddda to 680ae77 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
kiel-apple
reviewed
Oct 30, 2024
|
ignore the comments - going to just do them all in a commit and see if that works better |
kiel-apple
approved these changes
Oct 30, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36299: Size comparison from fe5ddda to 3c5c598 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
reviewed
Oct 31, 2024
examples/darwin-framework-tool/commands/common/CHIPToolKeypair.mm
Outdated
Show resolved
Hide resolved
|
PR #36299: Size comparison from fe5ddda to 6d6b952 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36299: Size comparison from fe5ddda to a3ba7d2 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…onal method calls
it's a test; this is the best we can do with an optional protocol method
remove comment - not this method's job to worry about other implementation's potential side-effects
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36299: Size comparison from fe5ddda to d5bfe8d Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 1, 2024
|
|
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 1, 2024
|
re-rolling in #36430 |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Initial checkin * Fixing review feedback * Adding braces * Restyled by clang-format * Fixing build * Restyled by clang-format * Fixing annotations * Update src/darwin/Framework/CHIP/MTRKeypair.h Co-authored-by: Boris Zbarsky <[email protected]> * separate statements involving _mPublicKey to make compiler happy * use `CFAutorelease` on CoreFoundation typed public key copies * fix indent * implement `copyPublicKey` for `MTRTestKeys`; add TODO note about optional method calls * remove comment it's a test; this is the best we can do with an optional protocol method * consistent formatting for `copyPublicKey` calls * reformat `copyPublicKey` in `MTRTestKeys` remove comment - not this method's job to worry about other implementation's potential side-effects * Update src/darwin/Framework/CHIP/MTRKeypair.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Kiel Oleson <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…36299)" (project-chip#36339) This reverts commit 08024d2 because it's failing CI as committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for CFTypes we need copy in front of them, otherwise it leaks