[Silabs]Split UniqueId and PersistentUniqueId #36292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
jmartinez-silabs
added
changing-submodules-on-purpose
jmartinez-silabs
force-pushed
the
bi_uniqueId
branch
from
69c99c9 to
4a2c2cd
Compare
|
PR #36292: Size comparison from fef41bd to 4a2c2cd Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 30, 2024
lpbeliveau-silabs
approved these changes
Oct 30, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakenly used the same Unique ID for the rotation Device ID and the UniqueID attribute from the basic information cluster. But they shall not be the same.
Our previously provisioned UniqueID remains untouched but it is now renamed PersitentUniqueID to make it clear it is not the same as the UniqueId Attribute as presented in spec. This PersitentUniqueId, once provision for example, at manufacturing time, stays on the device unaltered.
The UniqueID attribute from the basicInformation value is now stored in our NVM3 config section. It is erased on factory reset. After a factory reset, at init, we generate a random unique id. A user can store a New UniqueID at runtime if he decides to with StoreUniqueId()
This code already exists so the only change in this PR on this topic is having the kConfigKey_UniqueId in the NVM3 config section which is erased on factory reset